Revert symbol visibility changes #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…341)" This reverts commit 4153d01. Signed-off-by: Adam Glustein <[email protected]>
Signed-off-by: Adam Glustein <[email protected]>
AdamGlustein
requested review from
robambalu,
svatasoiu,
alexddobkin,
ptomecek and
timkpaine
as code owners
|
Closes #363 (temporarily) |
robambalu
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@svatasoiu and I have been trying for a while to get symbol visibility correct for users wanting to build extension modules. Unfortunately there have been some complications with Windows support so in the meantime, we will revert the hidden visibility change we made earlier.
Confirmed that the example extension modules work again after this reversion.