Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates BoringSSL to latest master #52

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

anathan
Copy link
Member

@anathan anathan commented Jun 11, 2023

This eliminates the need for the -werror removal patch and brings the latest security patches up to date.

@anathan anathan requested a review from axlan June 11, 2023 18:54
Copy link
Contributor

@axlan axlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, should we copy this in Nautilus?

@axlan
Copy link
Contributor

axlan commented Jun 12, 2023

Wait, actually the ARM build is failing with the exact reason the patch was added https://github.com/PointOneNav/polaris/actions/runs/5237026192/jobs/9454943865?pr=52 .

Either we shouldn't be building for ARM, or we still need to patch. For Nautilus it looks like we still need the patch, but should we still take the update?

@anathan
Copy link
Member Author

anathan commented Jun 14, 2023

We should definitely update, but we need to understand and test the ARM7 issue. We should see if anything is in the upstream boringSSL tickets as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants