Intermediate Release #877
Merged
Intermediate Release #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Describe your changes To reduce the amount and a time of AWS services usage - was decided to: - [X] Downgrade runner instance to c5d.4xlarge - [X] Run CI only in a specific conditions (when ready for review label is assigned, or currently in main or develop branch) ## Issue ticket number and link #847 ## Checklist before requesting a review - [X] I have performed a self-review of my code. - [ ] If it is a core feature, I have added thorough tests. - [X] I removed all Clippy and Formatting Warnings. - [ ] I added required Copyrights.
## Describe your changes Thea should generate the validator session change message at the beginning of the last epoch of an era and get the changes to effect at the end. ## Checklist before requesting a review - [x] I have performed a self-review of my code. - [ ] If it is a core feature, I have added thorough tests. - [x] I removed all Clippy and Formatting Warnings. - [ ] I added required Copyrights.
## Describe your changes Handles the corner case of session change in Thea
Implemented RPC to retrieve Checkpoints from Offchain Storage.
## Describe your changes Refactored offichain worker code for both Thea and Ocex Pallets.
## Describe your changes Handle checkpoints.
## Describe your changes Added logs for checkpoint handler.
## Describe your changes
After compiler version update - on attempt of `taplo` installation with
command `cargo install taplo-cli` we received multiple errors:
```
error[E0308]: mismatched types
--> /root/.cargo/registry/src/index.crates.io-6f17d22bba15001f/taplo-common-0.4.1/src/schema/mod.rs:555:29
|
555 | ... Arc::try_unwrap(schema).unwrap()
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected `&Value`, found `Value`
|
note: return type inferred to be `&serde_json::Value` here
--> /root/.cargo/registry/src/index.crates.io-6f17d22bba15001f/taplo-common-0.4.1/src/schema/mod.rs:507:13
|
507 | return;
| ^^^^^^
help: consider borrowing here
|
555 | &Arc::try_unwrap(schema).unwrap()
| +
error[E0308]: mismatched types
--> /root/.cargo/registry/src/index.crates.io-6f17d22bba15001f/taplo-common-0.4.1/src/schema/mod.rs:557:29
|
557 | ... all_of.clone()
| ^^^^^^^^^^^^^^ expected `&Value`, found `Value`
|
note: return type inferred to be `&serde_json::Value` here
--> /root/.cargo/registry/src/index.crates.io-6f17d22bba15001f/taplo-common-0.4.1/src/schema/mod.rs:507:13
|
507 | return;
| ^^^^^^
help: try removing the method call
|
557 - all_of.clone()
557 + all_of
|
error[E0308]: mismatched types
--> /root/.cargo/registry/src/index.crates.io-6f17d22bba15001f/taplo-common-0.4.1/src/schema/mod.rs:562:37
|
562 | merged_all_of.merge(schema);
| ----- ^^^^^^ expected `&Value`, found `Value`
| |
| arguments to this method are incorrect
|
note: method defined here
--> /root/.cargo/registry/src/index.crates.io-6f17d22bba15001f/json_value_merge-1.2.0/src/lib.rs:9:8
|
9 | fn merge(&mut self, new_value: &Value);
| ^^^^^
help: consider borrowing here
|
562 | merged_all_of.merge(&schema);
| +
For more information about this error, try `rustc --explain E0308`.
error: could not compile `taplo-common` (lib) due to 3 previous errors
warning: build failed, waiting for other jobs to finish...
error: failed to compile `taplo-cli v0.8.1`, intermediate artifacts can be found at `/tmp/cargo-installuTB8rU`.
To reuse those artifacts with a future compilation, set the environment variable `CARGO_TARGET_DIR` to that path.
Error: Process completed with exit code 101.
```
To fix this issue - used alternative method of installation with already
pre-compiled binary
([link](https://taplo.tamasfe.dev/cli/installation/binary.html)).
## Issue ticket number and link
No issue
## Checklist before requesting a review
- [X] I have performed a self-review of my code.
- [X] If it is a core feature, I have added thorough tests.
- [X] I removed all Clippy and Formatting Warnings.
- [X] I added required Copyrights.
## Describe your changes Patch: Commented unsafe checker
## Describe your changes A new binary is added that will check the deviation of off chain and on-chain balances for testing.
## Describe your changes Change Orderbook governance origin from Root to Root or General Council.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Checklist before requesting a review