Minor Release #952
Merged
Minor Release #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Describe your changes Updated withdraw.
## Describe your changes Snapshot progress stalls due to precision loss in balance between engine and off chain state. This PR modifies the logic to withdraw the whole amount if amount requested is greater than available balance instead of throwing errors.
## Describe your changes Fix claim_reward extrinsic.
…945) There is a filter on ProxyType::Any to remove the ability to do anything. This changes it to the intended purpose, to allow any. This was changed to false on 9/12/21 in this commit: 9c18e2b It should be set to true as the intent of ProxyType::Any is to allow all. It can be seen set to any in other chain implementations: https://github.com/moonbeam-foundation/moonbeam/blob/f99b3ef04c560ab47ad7d569d968808a040a0cd0/runtime/moonbeam/src/lib.rs#L1016 https://github.com/paritytech/substrate/blob/033d4e86cc7eff0066cd376b9375f815761d653c/bin/node/runtime/src/lib.rs#L372 ## Checklist before requesting a review - [x] I have performed a self-review of my code. - [x] If it is a core feature, I have added thorough tests. - [x] I removed all Clippy and Formatting Warnings. - [x] I added required Copyrights.
## Describe your changes Disable place bid until confirmation
… add-extension-verify-tests # Conflicts: # pallets/ocex/src/tests.rs
<!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced dynamic user registration upon their first deposit to enhance user experience. - **Refactor** - Enhanced signature verification for withdrawal requests to support both proxy and main accounts, improving security and error handling. - **Tests** - Added new tests for signature verification in orders and withdrawal requests. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
…s Pallet (#950) ## Describe your changes Added create_parachain_asset ext and removed sanity check from Rewards Pallet.
## Describe your changes Fixed LMP Bug.
|
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes