feat: dead click detection #1463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Size Change: +46.6 kB (+1.58%) Total Size: 3.01 MB
ℹ️ View Unchanged
|
pauldambra
commented
Oct 13, 2024
| import { uuidv7 } from '../../uuidv7' | ||
| import { DeadClicksAutocapture } from '../../extensions/dead-clicks-autocapture' | ||
|
|
||
| describe('DeadClicksAutocapture', () => { |
There was a problem hiding this comment.
this outer wrapper delegates entirely to the lazy loaded one so we can test it interacts with a mock as desired and ignore the behaviour
pauldambra
commented
Oct 13, 2024
src/autocapture.ts
Outdated
| @@ -37,6 +37,202 @@ function limitText(length: number, text: string): string { | |||
| return text | |||
| } | |||
|
|
|||
| export function getAugmentPropertiesFromElement(elem: Element): Properties { | |||
There was a problem hiding this comment.
a bunch of functions move out of the class so we can use them directly because they (mostly) don't rely on state of the class
it should help with bundle size a tiny bit since the names are now minifiable
pauldambra
commented
Oct 13, 2024
ioannisj
reviewed
Oct 14, 2024
richard-better
approved these changes
Oct 29, 2024
benjackwhite
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We autocapture valid webpage interactions
But some people will want to autocapture invalid interactions
for example in some places in posthog these "i" icons are clickable in others they aren't
deadclick autocapture lets you detect clicks that are not followed by scroll or DOM mutation, so you can see if folk are clicking things thinking something will happen and nothing happens
## Needs