Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a 'What's New?' button to the dropdown #14379

Merged
merged 8 commits into from
Feb 28, 2023
Merged

Conversation

joethreepwood
Copy link
Contributor

Problem

This is probably horribly, horribly wrong and broken - but I'm trying to step on toes and can't test it, so 🤷

As per #14378 it would be great if we could tell users, somehow, what new features have launched. Because we ship fast and don't want to send an email every time, add a banner every week, or trust that they check the blog all the time.

So: add a 'What's New?' button to the site app.

Changes

Adds a 'What's New?' button to the drop down.

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

How did you test this code?

I haven't because, for all my attempts and efforts, I still haven't had the product running successfully in a local env yet. Sorry!

Copy link
Collaborator

@Twixes Twixes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does make it possible to find the changelog, which is some sort of an improvement, though it doesn't make it very obvious. Let's merge this, because I don't see a reason not to, but I think the full solution would be an in-app changelog:

  • Either something like Discord's modal on app load, every month or so:

    image

  • Or a Sentry-style expandable list:

    Screenshot 2023-02-27 at 20 06 36

This is much more work though, and I'm not sure it's worth the effort at this moment, even though it'd be cool and effective in some way. So, LGTM!

I did make a fix to expand the HelpType, changed the icon from "coffee" to "live" and moved "What's new?" to the top:

Screenshot 2023-02-27 at 20 45 06

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted
  • firefox: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted
  • firefox: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@joethreepwood
Copy link
Contributor Author

I would absolutely love this to be an in-app pop-up modal, though if it's more work for you then it's definitely beyond my reach to PR. It's maybe worth considering as part of the new Changelog project though @corywatilo ?

@joethreepwood
Copy link
Contributor Author

Not sure why these tests are failing btw 🤷

@joethreepwood joethreepwood merged commit 140058d into master Feb 28, 2023
@joethreepwood joethreepwood deleted the whats-new-button branch February 28, 2023 11:29
fuziontech added a commit that referenced this pull request Feb 28, 2023
* master: (53 commits)
  fix: cut the undeterministic snapshots (#14461)
  feat(hogql): Events table based on hogql (#14315)
  fix(breakdown): ensure breakdown sort can sort through values of different types (#14459)
  feat(capture): gracefully catch non-string tokens (#14453)
  chore(plugin-server): add healthcheck logging for failure (#14455)
  fix(tests): Safer migrations (#14452)
  revert: "fix(person-overrides): add constraints to catch race conditions" (#14445)
  dev(codespaces): update to python3.10 (#14449)
  chore(deps): Update posthog-js to 1.50.0 (#14448)
  feat(capture): support LIGHTWEIGHT_CAPTURE_ENDPOINT_ENABLED_TOKENS=* (#14421)
  chore: upgrade d3 (#14442)
  fix(person-overrides): add constraints to catch race conditions (#14277)
  feat(cohorts): Remove postgres calculations for flags (#14272)
  feat(capture): check token shape before team resolution too (#14439)
  feat: dashboard templates (#14322)
  feat: add a 'What's New?' button to the dropdown (#14379)
  chore(recordings): don't DLQ on PostgreSQL errors (#14438)
  chore: update autocapture attribute capture (#14435)
  chore(recordings): remove hub dependency on recordings ingestion (#14418)
  chore(deps): Update posthog-js to 1.49.0 (#14436)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants