Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: "fix(person-overrides): add constraints to catch race conditions" #14445

Merged
merged 3 commits into from
Feb 28, 2023

Conversation

tiina303
Copy link
Contributor

Reverts #14277

see #inc-2023-02-28-elevated-error-rate-on-prod-us

@tiina303 tiina303 changed the title Revert "fix(person-overrides): add constraints to catch race conditions" revert: "fix(person-overrides): add constraints to catch race conditions" Feb 28, 2023
Copy link
Contributor

@hazzadous hazzadous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

We could also not add back the migration tests as that might make it annoying to get other code out if we need to and they start failing again.

@tiina303
Copy link
Contributor Author

We could also not add back the migration tests as that might make it annoying to get other code out if we need to and they start failing again.

lets do that separately - and I will go for smaller PRs in the future 😅

@tiina303 tiina303 merged commit c6b70c6 into master Feb 28, 2023
@tiina303 tiina303 deleted the revert-14277-fix/add-person-consrtaint-on-override branch February 28, 2023 15:48
fuziontech added a commit that referenced this pull request Feb 28, 2023
* master: (53 commits)
  fix: cut the undeterministic snapshots (#14461)
  feat(hogql): Events table based on hogql (#14315)
  fix(breakdown): ensure breakdown sort can sort through values of different types (#14459)
  feat(capture): gracefully catch non-string tokens (#14453)
  chore(plugin-server): add healthcheck logging for failure (#14455)
  fix(tests): Safer migrations (#14452)
  revert: "fix(person-overrides): add constraints to catch race conditions" (#14445)
  dev(codespaces): update to python3.10 (#14449)
  chore(deps): Update posthog-js to 1.50.0 (#14448)
  feat(capture): support LIGHTWEIGHT_CAPTURE_ENDPOINT_ENABLED_TOKENS=* (#14421)
  chore: upgrade d3 (#14442)
  fix(person-overrides): add constraints to catch race conditions (#14277)
  feat(cohorts): Remove postgres calculations for flags (#14272)
  feat(capture): check token shape before team resolution too (#14439)
  feat: dashboard templates (#14322)
  feat: add a 'What's New?' button to the dropdown (#14379)
  chore(recordings): don't DLQ on PostgreSQL errors (#14438)
  chore: update autocapture attribute capture (#14435)
  chore(recordings): remove hub dependency on recordings ingestion (#14418)
  chore(deps): Update posthog-js to 1.49.0 (#14436)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants