Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show dropped off users in FunnelStepTable #5315

Merged
merged 1 commit into from
Jul 23, 2021
Merged

Show dropped off users in FunnelStepTable #5315

merged 1 commit into from
Jul 23, 2021

Conversation

neilkakkar
Copy link
Collaborator

@neilkakkar neilkakkar commented Jul 23, 2021 •
edited
Loading

Changes

Currently, we show users who completed step X in the persons modal for dropped off users

Before: - when clicking the drop off number

image

Now:

image

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests
  • Migrations are safe to run at scale (e.g. PostHog Cloud) – present proof if not obvious
  • New/changed UI is decent on smartphones (viewport width around 360px)

@timgl timgl temporarily deployed to posthog-pr-5315 July 23, 2021 11:55 Inactive
@mariusandra mariusandra enabled auto-merge (squash) July 23, 2021 12:03
@mariusandra mariusandra merged commit 9630f31 into master Jul 23, 2021
@mariusandra mariusandra deleted the funnelstepsdropoff branch July 23, 2021 12:12
mariusandra pushed a commit that referenced this pull request Jul 23, 2021
@neilkakkar @mariusandra
Show dropped off users in modal (#5315)
a3fb7d2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariusandra mariusandra mariusandra approved these changes

@samwinslow samwinslow Awaiting requested review from samwinslow

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neilkakkar @mariusandra @timgl