Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show dropped off users in FunnelStepTable #5315

Merged
merged 1 commit into from
Jul 23, 2021
Merged

Show dropped off users in FunnelStepTable #5315

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions frontend/src/scenes/insights/InsightTabs/FunnelTab/FunnelStepTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,11 +95,7 @@ export function FunnelStepTable({}: FunnelStepTableProps): JSX.Element | null {
title: 'Dropped off',
render: function RenderDropoff({}, step: FlattenedFunnelStep): JSX.Element | null {
return step.order === 0 ? null : (
<ValueInspectorButton
onClick={() =>
openPersonsModal(step, step.order + 1, step.breakdown)
} /* TODO: does this modal support dropped off users? */
>
<ValueInspectorButton onClick={() => openPersonsModal(step, -(step.order + 1), step.breakdown)}>
{step.droppedOffFromPrevious}
</ValueInspectorButton>
)
Expand Down