fix the static build #2328
Merged
fix the static build #2328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- the isExecutable patch was broken, remove it - the ncurses fix was broken, we still need `enableStatic` - the original error was caused by the new ghc-bignum package, which isn't a "proper" Haskell package; we filter this out explicitly now
|
Works 🎉, on the CI artifact. |
Closed
steve-chavez
approved these changes
Jun 15, 2022
There was a problem hiding this comment.
LGTM! The pg 14 error in CI seems like a temporary one. We got the same on #2311 and when re-running the job it was cleared.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2327.
enableStaticpackage, which isn't a "proper" Haskell package; we filter
this out explicitly now