Accessibility: add aria-hidden (and some aria-label) #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
yannicka
commented
Jun 11, 2023
•
yannicka
commented
| Questions | Answers |
|---|---|
| Description? | The old PrestaShop theme had a number of accessibility problems. Let's try to do better with this new theme! This PR adds "aria-hidden" or "aria-label" to some elements. There's still a lot to do, but it's at least a start. |
| Type? | improvement |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | Improve #251 |
| Sponsor company | N/A |
| How to test? | Install the theme and test all pages |
matthieu-rolland
approved these changes
Jun 12, 2023
There was a problem hiding this comment.
thank you for your contribution @yannicka 👍
I'm not so familiar with aria-hidden, very nice idea indeed !
| data-action="show-password" | ||
| data-text-show="{l s='Show' d='Shop.Theme.Actions'}" | ||
| data-text-hide="{l s='Hide' d='Shop.Theme.Actions'}" | ||
| > | ||
| <i class="material-icons">visibility</i> |
There was a problem hiding this comment.
Is there a reason for not adding aria-hidden on this one ?
There was a problem hiding this comment.
@matthieu-rolland It's because the button does not have any text, so the icon actually serves a purpose.
There was a problem hiding this comment.
@matthieu-rolland Fixed on PR #508 ;)
Hlavtox
approved these changes
Jun 13, 2023
This was referenced Jun 15, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.