Show/Hide Password: Accessibility on the button #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
yannicka
commented
Jun 13, 2023
•
yannicka
commented
| Questions | Answers |
|---|---|
| Description? | Adds accessibility to the button to show/hide the password |
| Type? | improvement |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | Improve #251 |
| Sponsor company | N/A |
| How to test? | For a dev: Open dev console and sees aria-label and aria-expanded. (tested), for QA: see that showing/hiding password during registration works as expected. |
kpodemski
reviewed
Jun 13, 2023
src/js/visible-password.ts
Outdated
|
|
||
| const icon = button.firstElementChild; | ||
|
|
||
| if (icon) { | ||
| icon.innerHTML = newType === 'text' ? 'visibility_off' : 'visibility'; | ||
|
|
||
| const textShow = button.dataset.textShow; | ||
| const textHide = button.dataset.textHide; |
There was a problem hiding this comment.
Suggested change
| const textHide = button.dataset.textHide; | |
| const { textHide, textShow } = button.dataset; |
that should do it with eslint errors
kpodemski
approved these changes
Jun 16, 2023
matthieu-rolland
approved these changes
Jun 16, 2023
sallemiines
approved these changes
Jun 20, 2023
There was a problem hiding this comment.
Hello @yannicka
Thanx for the PR ! LGTM QA ✔️
You can check the attached screen recorder
810beta.1.mp4
Thank you !
|
Thank you @yannicka ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.