Rails 5.2 upgrade #166
Merged
Rails 5.2 upgrade #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tetramputechture
force-pushed
the
debt/rails-5.2
branch
from
3421e8c
to
13819a7
Compare
TheJayWright
suggested changes
Jul 24, 2018
| gem 'sass-rails', '~> 5.0' | ||
| gem 'slack-notifier', '~> 2.3.2' | ||
| gem 'turbolinks', '~> 5' | ||
| gem 'uglifier', '>= 1.3.0' | ||
| gem 'webpacker', '~> 3.5' | ||
|
|
||
| group :test do | ||
| gem 'minitest-rails-capybara' | ||
| gem 'capybara', '~> 2.18' |
There was a problem hiding this comment.
This capybara gem is not required when using the minitest-rails-capybara gem.
There was a problem hiding this comment.
This is technically correct, but because the gemspec for minitest-rails-capybara includes only capybara 2.7, and System Tests require greater than that, we can manually force a greater version of capybara by explicitly stating it.
There was a problem hiding this comment.
Just a heads up, it looks like minitest-rails-capybara is no longer being maintained since the system tests were added to rails. Here is the issue containing a blog post from the maintainer.
afomera
approved these changes
Jul 24, 2018
Tetramputechture
force-pushed
the
debt/rails-5.2
branch
from
13819a7
to
61faeb8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades Storm to Rails 5.2. Dependabot has the necessary gems upgraded in a separate PR (#143), but there was a little more to be done if we wanted our test suite to run, which was a simple Minitest workaround. I also made some changes to our config files, and set them up to be ready for ActiveStorage and CSP!
Tests still pass, and I thoroughly browser tested the site with no errors!