Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

History state #107

Closed
AndersGM opened this issue Jul 19, 2018 · 1 comment
Closed

History state #107

AndersGM opened this issue Jul 19, 2018 · 1 comment

Comments

@AndersGM
Copy link
Contributor

In the router package, the default behavior of popstate is prevented, and thus the state is not updated. Therefor the history.state cannot really be used (even though it works, as far is I can see, with hashbang:true).
Are there any reason for not replacing current state with the state received from the event?
I can of course make a pull request if you are interested.

Thanks for your great work!
Anders
caseyWebb added a commit that referenced this issue Jul 19, 2018
@caseyWebb
feat(router): Add state option for Router.update(); Use popstate even…
28becc8 
…t's state on back navigation

closes #107
@caseyWebb caseyWebb mentioned this issue Jul 19, 2018
Merged
@caseyWebb
Copy link
Contributor

No particular reason. Added in the PR above, and published in the latest rc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AndersGM @caseyWebb