Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Router.update() state option #108

Merged
merged 2 commits into from
Jul 20, 2018
Merged

Router.update() state option #108

merged 2 commits into from
Jul 20, 2018

Conversation

caseyWebb
Copy link
Contributor

Support setting the history state atomically, as well as preserve history.state on back button navigation (popstate).

Re: #107

@codecov
Copy link

codecov bot commented Jul 19, 2018

Codecov Report

Merging #108 into master will decrease coverage by 0.1%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #108      +/-   ##
==========================================
- Coverage   94.51%   94.41%   -0.11%     
==========================================
  Files          42       42              
  Lines         875      877       +2     
  Branches      187      187              
==========================================
+ Hits          827      828       +1     
- Misses         25       26       +1     
  Partials       23       23
Impacted Files Coverage Δ
packages/router/src/router.ts 86.18% <50%> (-0.49%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 048aa33...ed6875d. Read the comment docs.

@caseyWebb caseyWebb merged commit 1851f29 into master Jul 20, 2018
@caseyWebb caseyWebb deleted the popstate-history-state branch July 20, 2018 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant