Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Garage location does not update after moving #48

Closed
BackSH00TER opened this issue Jul 27, 2023 · 4 comments
Closed

Garage location does not update after moving #48

BackSH00TER opened this issue Jul 27, 2023 · 4 comments
Labels
needs duplicated

Comments

@BackSH00TER
Copy link
Contributor

Repro steps:

  1. As realtor go into /housing, Move Garage
  2. Place the garage at different coordinates, E to confirm
  3. Close the housing menu
  4. Actual: For the player who owns the property, the garage remains where it was previously.
  5. Expected: Garage coords should be in the new updated spot

Once you restart qb-garages and ps-housing then the garage location moves to the new coords
@BackSH00TER BackSH00TER added the bug Something isn't working label Jul 27, 2023
@LeSiiN LeSiiN added needs duplicated and removed bug Something isn't working labels Aug 11, 2023
@SKITTLE6969
Copy link

SKITTLE6969 commented Aug 13, 2023 •
edited
Loading

can confirm this, needs both scripts to be restarted otherwise house owner can see both old and new garage locations

#89 (comment)

@LeSiiN
Copy link
Contributor

LeSiiN commented Aug 22, 2023

updates on this one?

@MonkeyWhisper
Copy link
Member

I found the issue, there was two functions being called at the same time and was giving an issue
image

Property:UpdateGarage was duplicated

@Project-Sloth Project-Sloth deleted a comment from Maylortatebois Nov 20, 2023
Walter-00 added a commit to Walter-00/ps-housing that referenced this issue Nov 25, 2023
@Walter-00
Fix(Project-Sloth#48): Garage location should now update after moving it
b02c12a
@Walter-00 Walter-00 mentioned this issue Nov 25, 2023
Merged
1 task
@Walter-00
Copy link
Contributor

Hey @BackSH00TER,
This should be fixed in #156, please do try it out and lmk!

MonkeyWhisper pushed a commit that referenced this issue Nov 27, 2023
@Walter-00
Fixes for multiple issues (#156)
675dea1 
* fix(#140): Should fix target zone not getting removed when using OX

* Fix(#48): Garage location should now update after moving it

* Fix(#121): Should now show character creation even if not using starter apparments

* fix(#154): Should now be able to assign appartments when not having one already
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs duplicated
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@BackSH00TER @Walter-00 @MonkeyWhisper @SKITTLE6969 @LeSiiN