Migrate houses/apartments from qb-houses/qb-apartments

[xXJamieXx]

Overview

Finishes the migration code for converting from qb-houses and qb-apartments.

Details

The code was previously started but not fully functional.
Adds a list of shells with their corresponding "tiers" from qb-houses.
Houses requires a client to callback from to receive street and region data for each house.
Apartments are fairly straightforward.

UI Changes / Functionality

N/A

Testing Steps

From client or server run the migrateapartments command to convert all apartments from qb-apartments.
From client run migratehouses command to convert all houses from qb-houses. Must be run from client as it fetches street and region data.

• Did you test the changes you made?
• Did you test core functionality of the script to ensure your changes do not regress other areas?
• Did you test your changes in multiplayer to ensure it works correctly on all clients?

[ImXirvin]

I thought, this was unused because we check their previous apartment when its created, unsure about their house though. If this works, it wouldnt be bad to include.

Though it needs an admin check on the command.

@MonkeyWhisper It would be good to see some testers for this.

[BackSH00TER]

Lets update the readme as well with a note about these two commands for migrating existing qb apartments and houses over

[BackSH00TER]

I thought, this was unused because we check their previous apartment when its created, unsure about their house though. If this works, it wouldnt be bad to include.

Though it needs an admin check on the command.

@MonkeyWhisper It would be good to see some testers for this.

@ImXirvin I had only written up a migration for the apartment stashes. We didnt do anything to actually migrate existing apartments and houses over to ps-housing, this PR accomplishes that aspect.

[JnKTechstuff]

Tested and converted 270 properties and 7,740 apartments

[BackSH00TER]

@xXJamieXx Please update PR title to be a bit more descriptive, thx

[MonkeyWhisper]

We shall get a couple of people to test this to make sure all is working. Great PR, thanks @xXJamieXx

[MonkeyWhisper]

@xXJamieXx, can you add to the current README? Steps on what should be done, thanks!

[DustDevelopment]

Worked for me. No errors everything works the same. I only had one house to for it to transfer just fyi.

[SKITTLE6969]

I tried this with my existing database of 2k player apartments and 1.4k houses
Overall everything got converted but except apartments and housing stashes
Once I place the new stash it doesn't open the inventory for some reason
Also got an SQL error on live console here for each an every conversion

ps-housing/server/migrate.lua

Line 43 in dca4cff

shell = Config.Apartments[aptName].shell,

[MonkeyWhisper]

I tried this with my existing database of 2k player apartments and 1.4k houses Overall everything got converted but except apartments and housing stashes Once I place the new stash it doesn't open the inventory for some reason Also got an SQL error on live console here for each an every conversion

ps-housing/server/migrate.lua

Line 43 in dca4cff

shell = Config.Apartments[aptName].shell,

What's the error?

[SKITTLE6969]

[ script:ps-housing] SCRIPT ERROR: @ps-housing/server/server.lua:80: attempt to index a nil value (local 'player')
[ script:ps-housing] > (@oxmysql/dist/build.js:21810)
[ script:ps-housing] > runMicrotasks (:0)
[ script:ps-housing] > processTicksAndRejections (node:internal/process/task_queues:96)

script:ps-housing] Cannot add or update a child row: a foreign key constraint fails (QBCoreFramework_C5D6BE.properties, CONSTRAINT FK_owner_citizenid FOREIGN KEY (owner_citizenid) REFERENCES players (citizenid) ON DELETE CASCADE ON UPDATE CASCADE)
[ script:ps-housing] INSERT INTO properties (owner_citizenid, street, region, description, has_access, extra_imgs, furnitures, for_sale, price, shell, apartment, door_data, garage_data) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?) ["UZM72154",null,null,"This is Alta Street Apartments Apartment 187","[]","[]","[]",0,0,"Apartment Unfurnished","Alta Street Apartments","[]","[]"]

https://media.discordapp.net/attachments/1122815926455242822/1139481864650895370/Screenshot_20230811_142111_Chrome.jpg

[SKITTLE6969]

@MonkeyWhisper here's the console log

https://cdn.discordapp.com/attachments/1122815926455242822/1139483085730234438/fxserver_1691744241.log.txt

[MonkeyWhisper]

@MonkeyWhisper here's the console log

https://cdn.discordapp.com/attachments/1122815926455242822/1139483085730234438/fxserver_1691744241.log.txt

This issue is with your database table

script:ps-housing] Cannot add or update a child row: a foreign key constraint fails (QBCoreFramework_C5D6BE.properties, CONSTRAINT FK_owner_citizenid FOREIGN KEY (owner_citizenid) REFERENCES players (citizenid) ON DELETE CASCADE ON UPDATE CASCADE)

[SKITTLE6969]

@MonkeyWhisper here's the console log
https://cdn.discordapp.com/attachments/1122815926455242822/1139483085730234438/fxserver_1691744241.log.txt

This issue is with your database table

script:ps-housing] Cannot add or update a child row: a foreign key constraint fails (QBCoreFramework_C5D6BE.properties, CONSTRAINT FK_owner_citizenid FOREIGN KEY (owner_citizenid) REFERENCES players (citizenid) ON DELETE CASCADE ON UPDATE CASCADE)

ok i managed to sort that issue out, migratehouses command does nothing though O_O donsen't go after (print 5)

[xXJamieXx]

@MonkeyWhisper here's the console log
https://cdn.discordapp.com/attachments/1122815926455242822/1139483085730234438/fxserver_1691744241.log.txt

This issue is with your database table
script:ps-housing] Cannot add or update a child row: a foreign key constraint fails (QBCoreFramework_C5D6BE.properties, CONSTRAINT FK_owner_citizenid FOREIGN KEY (owner_citizenid) REFERENCES players (citizenid) ON DELETE CASCADE ON UPDATE CASCADE)

ok i managed to sort that issue out, migratehouses command does nothing though O_O donsen't go after (print 5)

Latest change should resolve this. Callback name was changed on client but not reflected on server. :)

[MonkeyWhisper]

@MonkeyWhisper here's the console log
https://cdn.discordapp.com/attachments/1122815926455242822/1139483085730234438/fxserver_1691744241.log.txt

This issue is with your database table
script:ps-housing] Cannot add or update a child row: a foreign key constraint fails (QBCoreFramework_C5D6BE.properties, CONSTRAINT FK_owner_citizenid FOREIGN KEY (owner_citizenid) REFERENCES players (citizenid) ON DELETE CASCADE ON UPDATE CASCADE)

ok i managed to sort that issue out, migratehouses command does nothing though O_O donsen't go after (print 5)

Latest change should resolve this. Callback name was changed on client but not reflected on server. :)

Shoot! That was my fault after I changed the callbacks name.

[SKITTLE6969]

okay now its working as intended, but I had to drop the garage vector column as it was giving me below error (2).
Without garage data everything was converted. When with garage location data some gets converted but the garage access or the box zone doesn't appear. If I try to remove the converted garage below error appears in Live Console. I'm using radial menu garages from JDev

Converted garages/houses have a different name compared to the original so the existing parked vehicles in garages don't sync with the converted ones

Also Housing stashes doesn't get converted like in apartment stashes.

(1)
[ script:ps-housing] SCRIPT ERROR: @ps-housing/server/sv_property.lua:383: attempt to index a nil value (local 'garage')
[ script:ps-housing] > ? (@ps-housing/server/sv_property.lua:383)
[ script:ps-housing] > handler (@ps-housing/server/server.lua:127)
[ script:ps-housing] > handler (@ps-realtor/server/server.lua:17)

(2)
[ script:ps-housing] SCRIPT ERROR: @ps-housing/server/migrate.lua:93: attempt to perform arithmetic on a nil value (field 'h')
[ script:ps-housing] > fn (@ps-housing/server/migrate.lua:93)

[MonkeyWhisper]

Tested and working on a QBCore default with changes.

[Sebaavv]

okay now its working as intended, but I had to drop the garage vector column as it was giving me below error (2). Without garage data everything was converted. When with garage location data some gets converted but the garage access or the box zone doesn't appear. If I try to remove the converted garage below error appears in Live Console. I'm using radial menu garages from JDev

Converted garages/houses have a different name compared to the original so the existing parked vehicles in garages don't sync with the converted ones

Also Housing stashes doesn't get converted like in apartment stashes.

(1) [ script:ps-housing] SCRIPT ERROR: @ps-housing/server/sv_property.lua:383: attempt to index a nil value (local 'garage') [ script:ps-housing] > ? (@ps-housing/server/sv_property.lua:383) [ script:ps-housing] > handler (@ps-housing/server/server.lua:127) [ script:ps-housing] > handler (@ps-realtor/server/server.lua:17)

(2) [ script:ps-housing] SCRIPT ERROR: @ps-housing/server/migrate.lua:93: attempt to perform arithmetic on a nil value (field 'h') [ script:ps-housing] > fn (@ps-housing/server/migrate.lua:93)

Any solution?