Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapter plugin #4

Merged
merged 40 commits into from
Aug 12, 2023
Merged

Adapter plugin #4

merged 40 commits into from
Aug 12, 2023

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Jul 14, 2023 •
edited
Loading

Overview

  1. Creating a Netlify flavored adapter plugin using their custom build output and no esbuild (see Adapter plugin greenwood-demo-adapter-vercel#4)

TODO

  1. API Routes are 404
  2. SSR page has an undefined error
  3. Same invalid URL error :/ - Static and Serverless Hosting Runtime Adapters greenwood#1008 (comment)
  4. Wait for Adapter Plugin API to be merged - Feature/issue 1008 adapter plugin API greenwood#1122
  5. Upstream adapter implementation (can drop netlify-cli dependency) and pull from npm
  6. Update README / merge / make public (only supports serverless right now)

@thescientist13 thescientist13 added enhancement New feature or request needs upstream labels Jul 14, 2023
@thescientist13
fix hardcoded import in output format template
33b7f70
@thescientist13
segment each API function with a folder and root index.js
63c0453
@thescientist13
output package.json with module type flag for SSR pages
2a7bfec
@thescientist13
generate a zip for custom functions build
af3851d
@thescientist13
custom zip implementation for SSR pages
378309e
@thescientist13
remove netlify directory from build output
76e5b75
@thescientist13
create zip inside netlify folder
acd49a0
@thescientist13
only output a zip file in netlify output dir
7787bc6
@thescientist13
commit simpler template output format
1077ea6
@thescientist13
commit simpler template output format
c3da6c6
@thescientist13
re-enable esbuild bundler in netlify.toml
daa9d33
@thescientist13
rename SSR page output after function name
14d16a0
@thescientist13
disable esbuild processing
0c3b2b5
@thescientist13
add back package.json
5b4e9d5
@thescientist13
restore template format output
cd03197
@thescientist13
code cleanup
7374203
@thescientist13
update README status
47cef30
@thescientist13
get API routes outputting correctly
0e31437
@thescientist13
move API adapter output to root of functions folder
822f6a7
@thescientist13
have API output entry point match route URL
199a296
@thescientist13
fix typo on netlify.toml redirect
4194434
@thescientist13
test dynamic splat redirecting for API routes in netlify.toml
668d8db
@thescientist13 thescientist13 mentioned this pull request Jul 15, 2023
Closed
2 tasks
This was referenced Jul 23, 2023
Merged
Merged
@thescientist13 thescientist13 mentioned this pull request Jul 23, 2023
Merged
12 tasks
@thescientist13 thescientist13 merged commit 31bc9ae into main Aug 12, 2023
4 checks passed
@thescientist13 thescientist13 deleted the adapter-plugin branch August 12, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request needs upstream
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@thescientist13