-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/issue 1008 netlify adapter plugin #1128
Merged
thescientist13
merged 19 commits into
release/0.29.0
from
feature/issue-1008-netlify-adapter-plugin
Aug 12, 2023
Merged
feature/issue 1008 netlify adapter plugin #1128
thescientist13
merged 19 commits into
release/0.29.0
from
feature/issue-1008-netlify-adapter-plugin
Aug 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thescientist13
added
documentation
Greenwood specific docs
Plugins
Greenwood Plugins
alpha.2
discussion
tied to an ongoing discussion or meeting notes
feature
New feature or request
v0.29.0
Adapter
labels
Jul 23, 2023
This was referenced Aug 5, 2023
thescientist13
force-pushed
the
feature/issue-1008-netlify-adapter-plugin
branch
from
August 12, 2023 14:32
f31e6c2
to
62efdaa
Compare
thescientist13
added a commit
that referenced
this pull request
Aug 12, 2023
* create initial working version of a netlify adapter plugin * add test case for greeting API route adapter * add test case for SSR page output * README clarifications * add fragments API and HTTP method support from Netlify event * file output setup and zipping refactoring * auto-generate _redirects file based on pages and APIs * redirects should be rewrites instead * document recommended Netlify project configuration setup * document caveats * link to demonstration repo * document adapter netlify on custom plugins page * add netlify-cli as a dependency * Netlify CLI integration and clarifications * disable linting due to typescript version conflicts * clarify redirects and rewrites in README * update pathname handling for windows interop * add test coverage for SSR pages content type * README refresh
thescientist13
added a commit
that referenced
this pull request
Nov 9, 2023
* create initial working version of a netlify adapter plugin * add test case for greeting API route adapter * add test case for SSR page output * README clarifications * add fragments API and HTTP method support from Netlify event * file output setup and zipping refactoring * auto-generate _redirects file based on pages and APIs * redirects should be rewrites instead * document recommended Netlify project configuration setup * document caveats * link to demonstration repo * document adapter netlify on custom plugins page * add netlify-cli as a dependency * Netlify CLI integration and clarifications * disable linting due to typescript version conflicts * clarify redirects and rewrites in README * update pathname handling for windows interop * add test coverage for SSR pages content type * README refresh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Adapter
alpha.2
discussion
tied to an ongoing discussion or meeting notes
documentation
Greenwood specific docs
feature
New feature or request
Plugins
Greenwood Plugins
v0.29.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
relates to #1008
Summary of Changes
TODO
manifest output options? - https://github.com/netlify/zip-it-and-ship-it#options- don't think it is neededbespoke copying of execute route module and API assets directories?- related to output consolidation and is being tracked in single file bundles (SFBs) for SSR page and API routes #1118Request
/Response
properties in adapter entry point, like headers and methodcontext
integration? (or track as own issue)text/html
content type #1138 and update test casesNetlify CLI support (e.g. local dev with Netlify CLI?)-import.meta.url
is broken 🤷♂️context
?