Adjusting BlockQuote and Shelf Styles #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| & blockquote { | ||
| margin:0.5em; | ||
| padding:15px; | ||
| background-color:#dcf9ca !important; |
There was a problem hiding this comment.
Nice, I really like how this looks!
I was playing around with different colors on the preview site just to see what it looked like for fun. Only thought is making sure that the background color is accessible in terms of providing good contrast between text and background color, but nothing major for now.
thescientist13
approved these changes
Aug 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
#91
Summary of Changes
This is an amendment to pull #146 by @aholtzman
cursor: pointerto shelf<blockquote>style with background and borderIgnoring the fact there's a mistake (should be 'use' not 'usage').