Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NFT specific pages #23

Merged
merged 9 commits into from
Feb 28, 2022
Merged

NFT specific pages #23

merged 9 commits into from
Feb 28, 2022

Conversation

qti3e
Copy link
Collaborator

@qti3e qti3e commented Feb 8, 2022

No description provided.

@b0xtch
Copy link
Contributor

b0xtch commented Feb 21, 2022

I created a pr for cap-js for the new function
I created a pr for rust-sdk for the new function
motoko one 🤷‍♂️

Otherwise looks MINT

Copy link
Contributor

@jsonsivar jsonsivar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


GetBucketResponse { canister, witness }
GetBucketResponse {
canister: ic::id(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just so I understand correctly, we are hard coding this because it's currently a single bucket and in the future when we change to multiple bucket canisters it would be based on the arg.id instead right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@qti3e qti3e merged commit 7430d3e into main Feb 28, 2022
@qti3e qti3e deleted the feat/nft branch February 28, 2022 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants