pyo3-build-config: conditionalize symbols on resolve-config feature #1859
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #1856 was buggy in that the
pyo3-build-config
crate didn't actuallywork in library mode because
include_str!()
was attempting to resolvemissing files as part of populating some
const
values.We could change the logic of these constants to make them lazy if
we wanted to support possibly getting access to the value. But the
simple solution is to conditionalize their presence on the crate
feature.
Test coverage for building and testing the crate in insolation with the
feature disabled has been added.
Various code has been conditionalized to avoid compiler warnings.
Also, it appears
cargo build|test -p pyo3-build-config --no-default-features
still passes default features. This seems wrongto me. But it is how my system behaves. Maybe it is an sccache bug?
I coded the new tests to
cd pyo3-build-config
first to work around.