Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyo3-build-config: conditionalize symbols on resolve-config feature #1859

Merged
merged 1 commit into from
Sep 3, 2021

Commits on Sep 3, 2021

  1. pyo3-build-config: conditionalize symbols on resolve-config feature

    PR PyO3#1856 was buggy in that the `pyo3-build-config` crate didn't actually
    work in library mode because `include_str!()` was attempting to resolve
    missing files as part of populating some `const` values.
    
    We could change the logic of these constants to make them lazy if
    we wanted to support possibly getting access to the value. But the
    simple solution is to conditionalize their presence on the crate
    feature.
    
    Test coverage for building and testing the crate in insolation with the
    feature disabled has been added.
    
    Various code has been conditionalized to avoid compiler warnings.
    
    Also, it appears `cargo build|test -p pyo3-build-config
    --no-default-features` still passes default features. This seems wrong
    to me. But it is how my system behaves. Maybe it is an sccache bug?
    I coded the new tests to `cd pyo3-build-config` first to work around.
    indygreg committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    3957afc View commit details
    Browse the repository at this point in the history