Skip to content

Commit

Permalink
Update qiskit_bot regex for rust file change trigger (#7929)
Browse files Browse the repository at this point in the history
* Update qiskit_bot regex for rust file change trigger

This commit updates the regex path trigger used for qiskit-bot's
reviewer notification for changes to rust source files. The intent of
the regex was to match any path ending with .rs which indicates it was a
rust source file. However, the regex was overly broad and would match
any file that had rs in it as was recently found in #7924. [1] This
commit fixes this by making the regex more specific, it also adds an or
condition to trigger on changes to Cargo files in the root of the repo
which are the build configs for the rust code.

[1] #7924 (comment)

* Add notification trigger for visualizations

In code review enavarro51 asked to be added to the notification list
for changes to the visualization (excluding the pulse drawers). This
commit adds a new notification regex key to do this and will notify him
on PRs that touch these files.

* Add missing @

Co-authored-by: Jake Lishman <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
  • Loading branch information
3 people authored Apr 14, 2022
1 parent b074d7a commit 36a3d96
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion qiskit_bot.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,9 @@ notifications:
- "@t-imamichi"
- "@ajavadia"
- "@levbishop"
".*rs":
".*\\.rs$|^Cargo":
- "@mtreinish"
- "@kevinhartman"
"(?!.*pulse.*)\\bvisualization\\b":
- "@enavarro51"
always_notify: true

0 comments on commit 36a3d96

Please sign in to comment.