Update qiskit_bot regex for rust file change trigger #7929
Conversation
This commit updates the regex path trigger used for qiskit-bot's reviewer notification for changes to rust source files. The intent of the regex was to match any path ending with .rs which indicates it was a rust source file. However, the regex was overly broad and would match any file that had rs in it as was recently found in Qiskit#7924. [1] This commit fixes this by making the regex more specific, it also adds an or condition to trigger on changes to Cargo files in the root of the repo which are the build configs for the rust code. [1] Qiskit#7924 (comment)
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 2168312573
💛 - Coveralls |
|
@mtreinish Can you add me to the list for non-pulse visualizations? I believe |
In code review enavarro51 asked to be added to the notification list for changes to the visualization (excluding the pulse drawers). This commit adds a new notification regex key to do this and will notify him on PRs that touch these files.
Sure, np. Done in 31b481d |
Summary
This commit updates the regex path trigger used for qiskit-bot's
reviewer notification for changes to rust source files. The intent of
the regex was to match any path ending with .rs which indicates it was a
rust source file. However, the regex was overly broad and would match
any file that had rs in it as was recently found in #7924. [1] This
commit fixes this by making the regex more specific, it also adds an or
condition to trigger on changes to Cargo files in the root of the repo
which are the build configs for the rust code.
Details and comments
[1] #7924 (comment)