Move utility functions _inverse_pattern and _get_ordered_swap to Rust #12327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiskit-bot
added
the
Community PR
|
|
mtreinish
added
performance
synthesis
Rust
Pull Request Test Coverage Report for Build 9411521330Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
jpacold
requested review from
alexanderivrii,
ShellyGarion and
a team
as code owners
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
|
Is this still a work in progress? @jpacold if it's not, it would be helpful to remove the [WIP] from the title as it seems to me this has been completed. |
jpacold
changed the title
|
@raynelfss Done, thanks for pointing that out. |
raynelfss
previously approved these changes
May 30, 2024
Co-authored-by: Raynel Sanchez <[email protected]>
Co-authored-by: Raynel Sanchez <[email protected]>
Cryoris
reviewed
Jun 6, 2024
ShellyGarion
reviewed
Jun 6, 2024
Cryoris
reviewed
Jun 7, 2024
There was a problem hiding this comment.
LGTM thanks for the updates! If @ShellyGarion and @raynelfss are good with it I think we can merge 👍🏻
Edit: both are good with the changes 🙂
Cryoris
approved these changes
Jun 10, 2024
Cryoris
added a commit
to Cryoris/qiskit-terra
that referenced
this pull request
Jun 19, 2024
also port circuit construction to rust and add a reno
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 24, 2024
* Follow up on #12327 also port circuit construction to rust and add a reno * move _get_ordered_swap to Rust only * drop redundant Ok(expect()) * proper synthesis structure
Procatv
pushed a commit
to Procatv/qiskit-terra-catherines
that referenced
this pull request
Aug 1, 2024
…Qiskit#12327) * Move utility functions _inverse_pattern and _get_ordered_swap to Rust * fix formatting and pylint issues * Changed input type to `PyArrayLike1<i64, AllowTypeChange>` * Refactor `permutation.rs`, clean up imports, fix coverage error * fix docstring for `_inverse_pattern` Co-authored-by: Raynel Sanchez <[email protected]> * fix docstring for `_get_ordered_swap` Co-authored-by: Raynel Sanchez <[email protected]> * remove pymodule nesting * remove explicit `AllowTypeChange` * Move input validation out of `_inverse_pattern` and `_get_ordered_swap` --------- Co-authored-by: Raynel Sanchez <[email protected]>
Procatv
pushed a commit
to Procatv/qiskit-terra-catherines
that referenced
this pull request
Aug 1, 2024
* Follow up on Qiskit#12327 also port circuit construction to rust and add a reno * move _get_ordered_swap to Rust only * drop redundant Ok(expect()) * proper synthesis structure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR starts addressing #12225. I moved the implementations of two functions from qiskit/synthesis/permutation/permutation_utils.py to Rust.
Details and comments
Created permutation.rs
_get_ordered_swapuses the same logic as it did in Python.Added a module
qiskit._accelerate.permutationand a submoduleqiskit._accelerate.permutation.permutation_utils(following the structure of the existing Python modules). The wrapped functions are in thepermutation_utilssubmodule.Replaced the function bodies in
permutation_utils.pywith calls to the Rust functions.Added tests.
Performance
As expected, this implementation of
_get_ordered_swapis faster than the Python version. However, the input type is expected to be an array ofint64and there is a performance cost for converting from any other type. On my machine:int64)int32,uint32, oruint64)For now, I don't think this matters much, because the bottleneck in
synth_permutation_basicis constructing the circuit, but it is something that might need to be optimized later on.