Follow up on #12327: circuit construction in Rust #12605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also port circuit construction to rust and add a reno
Cryoris
requested review from
alexanderivrii,
ShellyGarion and
a team
as code owners
|
One or more of the following people are relevant to this code:
|
Cryoris
added
performance
synthesis
Rust
mtreinish
reviewed
Jun 19, 2024
Pull Request Test Coverage Report for Build 9582110172Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9592874352Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
mtreinish
reviewed
Jun 20, 2024
|
I've also added the module structure in bb03417 as discussed with @ShellyGarion, so after this merged we can follow it in the other open PRs 🙂 |
Pull Request Test Coverage Report for Build 9610157167Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
alexanderivrii
approved these changes
Jun 24, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
ShellyGarion
approved these changes
Jun 24, 2024
ElePT
added
Changelog: New Feature
Procatv
pushed a commit
to Procatv/qiskit-terra-catherines
that referenced
this pull request
Aug 1, 2024
* Follow up on Qiskit#12327 also port circuit construction to rust and add a reno * move _get_ordered_swap to Rust only * drop redundant Ok(expect()) * proper synthesis structure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#12327 ported the utility functions for
synth_permutation_basicto Rust, but not the circuit construction which, at the time, wasn't possible. Now that we can construct circuits in Rust directly, this PR follows up by doing exactly that (and also adds a reno).