-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set a dummy QISKIT_SETTINGS so tests do not interact with local env #12463
Conversation
One or more of the following people are relevant to this code:
|
Pull Request Test Coverage Report for Build 9790432013Details
💛 - Coveralls |
test/utils/base.py
Outdated
"""Qiskit-specific further additions for test cases, if ``testtools`` is available. | ||
|
||
It is not normally safe to derive from this class by name; on import, Terra checks if the | ||
It is not normally safe to derive from this class by name; on import, Qiskit checks if the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unrelated. Just removing Terra things.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aha, I see, it's been moved to #12720. LGTM.
Fwiw, this was already handled by Tests that can be influenced unduly by options in the settings file should probably be passing the options precisely within the tests to avoid this. |
…iskit#12463) * mock QISKIT_SETTINGS to avoid interfering with my own env * set a dummy QISKIT_SETTINGS to avoid interfering with local env * apply to all of them * revert
Some of the tests were failing with in my machine and I noticed that it was because my particular setting in
~/.qiskit/settings.conf
. Tests should not depend on the situation of thesetting.conf
.This PR sets a dummy
QISKIT_SETTINGS
to avoid that.