Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify base TestCases #12720

Merged
merged 3 commits into from
Jul 5, 2024
Merged

Simplify base TestCases #12720

merged 3 commits into from
Jul 5, 2024

Conversation

1ucian0
Copy link
Member

@1ucian0 1ucian0 commented Jul 4, 2024

Removing the complexity in the TestCases class hierarchy. Additionally, removing the terra mentions.

@1ucian0 1ucian0 requested a review from a team as a code owner July 4, 2024 08:05
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@1ucian0 1ucian0 added Changelog: None Do not include in changelog type: qa Issues and PRs that relate to testing and code quality labels Jul 4, 2024
@coveralls
Copy link

coveralls commented Jul 4, 2024

Pull Request Test Coverage Report for Build 9790725826

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 26 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.04%) to 89.809%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/expr.rs 1 94.02%
crates/qasm2/src/lex.rs 7 91.35%
crates/qasm2/src/parse.rs 18 96.69%
Totals Coverage Status
Change from base Build 9785044203: -0.04%
Covered Lines: 65108
Relevant Lines: 72496

💛 - Coveralls

Copy link
Contributor

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense to remove the base class, I added two small wording suggestions, but LGTM.

test/utils/base.py Outdated Show resolved Hide resolved
test/utils/base.py Outdated Show resolved Hide resolved
1ucian0 and others added 2 commits July 4, 2024 11:46
Co-authored-by: Elena Peña Tapia <[email protected]>
Co-authored-by: Elena Peña Tapia <[email protected]>
@coveralls
Copy link

coveralls commented Jul 4, 2024

Pull Request Test Coverage Report for Build 9792154196

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 23 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.03%) to 89.817%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 5 92.11%
crates/qasm2/src/parse.rs 18 96.69%
Totals Coverage Status
Change from base Build 9785044203: -0.03%
Covered Lines: 65114
Relevant Lines: 72496

💛 - Coveralls

@1ucian0
Copy link
Member Author

1ucian0 commented Jul 4, 2024

I added two small wording suggestions

accepting both.

Copy link
Contributor

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ElePT ElePT added this pull request to the merge queue Jul 5, 2024
Merged via the queue into Qiskit:main with commit bb60891 Jul 5, 2024
15 checks passed
Procatv pushed a commit to Procatv/qiskit-terra-catherines that referenced this pull request Aug 1, 2024
* Merge base classes for testing

* Update test/utils/base.py

Co-authored-by: Elena Peña Tapia <[email protected]>

* Update test/utils/base.py

Co-authored-by: Elena Peña Tapia <[email protected]>

---------

Co-authored-by: Elena Peña Tapia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog type: qa Issues and PRs that relate to testing and code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants