Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set version number to 1.2.0rc1 for first release candidate #12867

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

mtreinish
Copy link
Member

Summary

For the 1.2.0 release we're going to push release candidates prior to the final to enable testing before we cut the final release. In preparation for tagging the first release candidate this commit updates the version string to indicate it's a release candidate. This commit should be the final commit on main for 1.2.0rc1 and what gets tagged as 1.2.0rc1 post-merge.

Details and comments

For the 1.2.0 release we're going to push release candidates prior to
the final to enable testing before we cut the final release. In
preparation for tagging the first release candidate this commit updates
the version string to indicate it's a release candidate. This commit
should be the final commit on main for 1.2.0rc1 and what gets tagged as
1.2.0rc1 post-merge.
@mtreinish mtreinish added the Changelog: None Do not include in changelog label Jul 31, 2024
@mtreinish mtreinish added this to the 1.2.0 milestone Jul 31, 2024
@mtreinish mtreinish requested a review from a team as a code owner July 31, 2024 13:36
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

@mtreinish mtreinish added the on hold Can not fix yet label Jul 31, 2024
@ElePT
Copy link
Contributor

ElePT commented Jul 31, 2024

releasenotes/notes/1.2/oxidize-permbasic-be27578187ac472f.yaml also contains an "upgrade" reno that should be changed to a feature reno or removed (not super informative, just mentions porting to Rust, see #12605). I didn't add a changelog label to the PR because I wasn't sure which one to add (reminder for the actual release).

Copy link
Contributor

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I can re-approve if there are further changes.

@mtreinish mtreinish removed the on hold Can not fix yet label Aug 1, 2024
@jakelishman
Copy link
Member

Ok, with #12881 now in the merge queue for 1.2.0rc1, let's get this into the queue after it.

@jakelishman jakelishman added this pull request to the merge queue Aug 1, 2024
Merged via the queue into Qiskit:stable/1.2 with commit 57bf058 Aug 1, 2024
15 checks passed
@mtreinish mtreinish deleted the rc1-12 branch August 1, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants