Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for sklearn 1.3.0 #74

Merged
merged 13 commits into from
Jul 27, 2023
Merged

Add support for sklearn 1.3.0 #74

merged 13 commits into from
Jul 27, 2023

Conversation

pavelzw
Copy link
Member

@pavelzw pavelzw commented Jul 26, 2023

Closes #65

scikit-learn/scikit-learn#23595 added the missing_go_to_left option to the state.

@jonashaag
Copy link
Contributor

Code looks good but do you want to drop scikit-learn < 1.3?

@github-actions
Copy link

github-actions bot commented Jul 26, 2023

(benchmark 5682661631 / attempt 1)
Base results / Our results / Change

Model Size Dump Time Load Time
sklearn rf 20M 23.4 MiB / 3.0 MiB / 7.67 x 0.02 s / 0.06 s / 2.46 x 0.02 s / 0.06 s / 2.92 x
sklearn rf 20M lzma 7.6 MiB / 2.0 MiB / 3.78 x 17.76 s / 1.56 s / 0.09 x 0.72 s / 0.25 s / 0.35 x
sklearn rf 200M 238.8 MiB / 30.8 MiB / 7.75 x 0.19 s / 0.42 s / 2.19 x 0.23 s / 0.61 s / 2.64 x
sklearn rf 200M lzma 49.9 MiB / 14.8 MiB / 3.37 x 148.62 s / 23.26 s / 0.16 x 5.52 s / 2.03 s / 0.37 x
sklearn rf 1G 1302.2 MiB / 168.0 MiB / 7.75 x 1.40 s / 2.33 s / 1.66 x 1.38 s / 3.02 s / 2.18 x
sklearn rf 1G lzma 295.9 MiB / 99.1 MiB / 2.99 x 870.41 s / 140.22 s / 0.16 x 31.26 s / 11.55 s / 0.37 x
sklearn gb 2M 2.5 MiB / 1.1 MiB / 2.16 x 0.05 s / 0.46 s / 9.35 x 0.07 s / 0.47 s / 6.72 x
sklearn gb 2M lzma 0.7 MiB / 0.2 MiB / 4.46 x 1.36 s / 0.65 s / 0.48 x 0.14 s / 0.42 s / 2.99 x
lgbm gbdt 2M 5.3 MiB / 3.6 MiB / 1.47 x 0.12 s / 0.38 s / 3.08 x 0.02 s / 0.15 s / 9.31 x
lgbm gbdt 2M lzma 0.9 MiB / 1.3 MiB / 0.66 x 4.05 s / 2.73 s / 0.67 x 0.11 s / 0.31 s / 2.84 x
lgbm gbdt 5M 10.7 MiB / 7.2 MiB / 1.48 x 0.20 s / 0.67 s / 3.42 x 0.03 s / 0.32 s / 10.23 x
lgbm gbdt 5M lzma 1.7 MiB / 2.5 MiB / 0.66 x 9.55 s / 6.18 s / 0.65 x 0.20 s / 0.58 s / 2.92 x
lgbm gbdt 20M 45.3 MiB / 30.2 MiB / 1.50 x 0.79 s / 2.81 s / 3.54 x 0.14 s / 1.41 s / 9.75 x
lgbm gbdt 20M lzma 12.6 MiB / 9.4 MiB / 1.34 x 51.66 s / 32.27 s / 0.62 x 1.38 s / 2.47 s / 1.78 x
lgbm gbdt 100M 202.2 MiB / 134.1 MiB / 1.51 x 3.67 s / 12.64 s / 3.44 x 0.73 s / 32.72 s / 44.54 x
lgbm gbdt 100M lzma 51.2 MiB / 36.3 MiB / 1.41 x 234.20 s / 146.58 s / 0.63 x 5.78 s / 9.45 s / 1.63 x
lgbm rf 10M 21.8 MiB / 14.0 MiB / 1.55 x 0.39 s / 0.83 s / 2.13 x 0.06 s / 0.54 s / 8.39 x
lgbm rf 10M lzma 1.4 MiB / 1.1 MiB / 1.28 x 5.06 s / 3.34 s / 0.66 x 0.23 s / 0.66 s / 2.85 x

Copy link
Contributor

@StefanSorgQC StefanSorgQC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for supporting scikit-learn = 1.3, that is very helpful!

environment-deprecated.yml Outdated Show resolved Hide resolved
slim_trees/sklearn_tree.py Outdated Show resolved Hide resolved
@pavelzw pavelzw added the bug Something isn't working label Jul 27, 2023
@pavelzw pavelzw merged commit 8c69096 into main Jul 27, 2023
16 checks passed
@pavelzw pavelzw deleted the sklearn-1.3.0 branch July 27, 2023 18:14
@pavelzw pavelzw mentioned this pull request Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests are failing for scikit-learn=1.3.0
4 participants