Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for lightgbm 4 #75

Merged
merged 8 commits into from
Jul 27, 2023
Merged

Add support for lightgbm 4 #75

merged 8 commits into from
Jul 27, 2023

Conversation

pavelzw
Copy link
Member

@pavelzw pavelzw commented Jul 27, 2023

Closes #72

@pavelzw pavelzw requested a review from jonashaag July 27, 2023 12:28
@pavelzw
Copy link
Member Author

pavelzw commented Jul 27, 2023

Let's merge this before #74 since this has a better CI setup.

@@ -32,12 +45,18 @@ jobs:
python=${{ matrix.PYTHON_VERSION }}
pytest-md
pytest-emoji
scikit-learn${{ matrix.SKLEARN_VERSION != '' && '=' || '' }}${{ matrix.SKLEARN_VERSION }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could just make SKLEARN_VERSION a matchspec

SKLEARN_VERSION: 'sklearn=1.1'
SKLEARN_VERSION: 'sklearn>0'

@github-actions
Copy link

github-actions bot commented Jul 27, 2023

(benchmark 5682617770 / attempt 1)
Base results / Our results / Change

Model Size Dump Time Load Time
sklearn rf 20M 20.8 MiB / 3.0 MiB / 6.87 x 0.02 s / 0.05 s / 2.57 x 0.02 s / 0.04 s / 2.18 x
sklearn rf 20M lzma 6.5 MiB / 2.0 MiB / 3.26 x 15.72 s / 1.55 s / 0.10 x 0.67 s / 0.22 s / 0.33 x
sklearn rf 200M 212.3 MiB / 30.6 MiB / 6.94 x 0.15 s / 0.37 s / 2.44 x 0.19 s / 0.33 s / 1.73 x
sklearn rf 200M lzma 47.4 MiB / 14.6 MiB / 3.24 x 122.16 s / 22.45 s / 0.18 x 5.26 s / 1.73 s / 0.33 x
sklearn rf 1G 1157.5 MiB / 166.8 MiB / 6.94 x 1.10 s / 1.85 s / 1.68 x 1.14 s / 1.61 s / 1.41 x
sklearn rf 1G lzma 258.1 MiB / 98.1 MiB / 2.63 x 629.81 s / 125.72 s / 0.20 x 28.31 s / 10.30 s / 0.36 x
sklearn gb 2M 2.2 MiB / 1.1 MiB / 2.08 x 0.04 s / 0.33 s / 7.71 x 0.05 s / 0.16 s / 3.34 x
sklearn gb 2M lzma 0.6 MiB / 0.2 MiB / 3.80 x 1.18 s / 0.52 s / 0.44 x 0.11 s / 0.17 s / 1.62 x
lgbm gbdt 2M 2.6 MiB / 1.0 MiB / 2.78 x 0.11 s / 0.31 s / 2.94 x 0.02 s / 0.14 s / 9.19 x
lgbm gbdt 2M lzma 0.9 MiB / 0.5 MiB / 1.90 x 1.78 s / 0.63 s / 0.36 x 0.10 s / 0.19 s / 1.95 x
lgbm gbdt 5M 5.3 MiB / 1.9 MiB / 2.81 x 0.18 s / 0.57 s / 3.15 x 0.03 s / 0.29 s / 9.75 x
lgbm gbdt 5M lzma 1.7 MiB / 0.8 MiB / 1.96 x 4.40 s / 1.34 s / 0.30 x 0.18 s / 0.37 s / 2.03 x
lgbm gbdt 20M 22.7 MiB / 7.6 MiB / 3.00 x 0.73 s / 2.40 s / 3.28 x 0.14 s / 1.21 s / 8.78 x
lgbm gbdt 20M lzma 6.3 MiB / 3.0 MiB / 2.09 x 22.86 s / 6.02 s / 0.26 x 0.73 s / 1.46 s / 1.99 x
lgbm gbdt 100M 101.1 MiB / 33.0 MiB / 3.06 x 3.30 s / 10.44 s / 3.17 x 0.61 s / 78.19 s / 128.90 x
lgbm gbdt 100M lzma 25.6 MiB / 10.6 MiB / 2.41 x 114.62 s / 29.03 s / 0.25 x 3.01 s / 6.24 s / 2.07 x
lgbm rf 10M 10.9 MiB / 3.2 MiB / 3.46 x 0.37 s / 0.77 s / 2.08 x 0.05 s / 0.48 s / 9.30 x
lgbm rf 10M lzma 0.7 MiB / 0.4 MiB / 1.86 x 2.28 s / 1.14 s / 0.50 x 0.14 s / 0.52 s / 3.62 x

@pavelzw pavelzw merged commit 56108c5 into main Jul 27, 2023
15 checks passed
@pavelzw pavelzw deleted the lightgbm-4 branch July 27, 2023 15:43
@pavelzw pavelzw added the bug Something isn't working label Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests are failing for lightgbm==4.0.0
2 participants