Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove rdflib_jsonld dependency #46

Closed
wants to merge 1 commit into from
Closed

remove rdflib_jsonld dependency #46

wants to merge 1 commit into from

Conversation

Panaetius
Copy link

fixes #45

But this means that RDFLib < 6.0.0 doesn't work anymore

@Panaetius Panaetius mentioned this pull request Sep 8, 2021
Merged
@ashleysommer
Copy link
Collaborator

ashleysommer commented Sep 9, 2021 •
edited
Loading

Woops, sorry, ignore my previous message here. I thought this was the PySHACL issue, but it is the OWL-RL issue.

@ashleysommer
Copy link
Collaborator

I have a better idea to fix this.

  1. Remove json-ld from requirements
  • OWL-RL imports rdflib_jsonld in a try: except wrapper anyway. Its an optional feature
  1. Detect if RDFLib 6.0+ is in use, if so set json_ld_available=True without importing the module.

That will allow OWL-RL to continue to work on RDFLib 5.0.0 and 6.0.0.

@ashleysommer ashleysommer mentioned this pull request Sep 12, 2021
Merged
@Panaetius
Copy link
Author

Closed in favor of #47

@Panaetius Panaetius closed this Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rdflib_jsonld breaks install, replace with RDFLib 6.0 integrated version
2 participants
@Panaetius @ashleysommer