Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rdflib 6.0 and json-ld fixes #47

Merged
merged 1 commit into from
Sep 13, 2021
Merged

Rdflib 6.0 and json-ld fixes #47

merged 1 commit into from
Sep 13, 2021

Conversation

ashleysommer
Copy link
Collaborator

Fixes #45
Replaces #46

Changes:

  • Bump min rdflib to v5.0.0
  • Remove json-ld from requirements
    • OWL-RL imports rdflib_jsonld in a try: except wrapper anyway. Its an optional feature
  • Detect if RDFLib 6.0+ is in use, if so set json_ld_available=True without importing the module.

 - OWL-RL imports rdflib_jsonld in a `try: except` wrapper anyway. Its an optional feature
Detect if RDFLib 6.0+ is in use, if so set `json_ld_available=True` without importing the module.
@ashleysommer
Copy link
Collaborator Author

@nicholascar
Can you please review and merge, though I'm not sure how to correctly put out a new OWL-RL release.

@nicholascar
Copy link
Member

Can you please review and merge...

Sure, will do a bunch of rdflib reviews tonight.

...though I'm not sure how to correctly put out a new OWL-RL release.

I've got access to OWL-RL on GitHub & PiPY, so I should be able to put updates through.

Copy link

@Panaetius Panaetius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, this is a better solution than the one in #46, I'll close that PR in favor of this one.

@nicholascar nicholascar merged commit 9c533d2 into master Sep 13, 2021
@nicholascar nicholascar deleted the rdflib6_fix branch September 13, 2021 10:21
@nicholascar
Copy link
Member

version tagged, readthedocs updated and PyPI version released: 5.2.2

@ashleysommer
Copy link
Collaborator Author

ashleysommer commented Sep 13, 2021

Thanks Nick!
As a direct result of this:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rdflib_jsonld breaks install, replace with RDFLib 6.0 integrated version
3 participants