[Input] Final Fixes (MMJOY + evdev) #3817

Megamouse · 2017-11-30T20:13:58Z

flash-fire · 2017-11-30T20:38:53Z

If this is actually your last PR for this, I promise to shave my head.

Psycho-A · 2017-12-02T20:26:18Z

Will be plans to implement a mouse axis as some of gamepad's analog sticks? It would be great in the end! :)

Psycho-A · 2017-12-02T20:44:57Z

Found first bugs with this PR.
Keyboard now is totally buggy. I binded Shift as R1 button, and WASD to Left stick, and now I can't control WASD keys when shift is pressed. Probably the same thing happen with some other buttons too. Also, low fps now borns wild input lags with button stucking, f.e. my character was forced to move left when left direction on stick were released during low fps.

Megamouse · 2017-12-02T21:15:19Z

try again @Psycho-A

Psycho-A · 2017-12-03T15:09:44Z

@Megamouse
works well as before.

toccata10 · 2017-12-06T12:27:03Z

Hi Megamouse,
A bit of testing with the evdev part:
*with this PR: ok for an xbox360 controller. Vibrations are cool too.

With my custom stick:
*on master: works fine except that the analog axis are reversed: it's ok on the config window, but when in a game: if I press up, it goes down. If I press right, it goes left.
Correct in gui window, wrong in games:

Workaround: I press left to register right input in the config window.
Dpad is perfect.
Incorrect in gui window, correct in games:

So, while not perfect, it's very easy to configure.

*on PR: I can't register LX-, neither LY-: it always registers LZ+
So it seems like LX- and LY- are not captured.
Knowing that with an evtest, this is my output (so if I don't press anything, the gui always captures a LZ+):

Event: time 1512561543.089711, -------------- SYN_REPORT ------------
Event: time 1512561543.097704, type 3 (EV_ABS), code 2 (ABS_Z), value 133
Event: time 1512561543.097704, -------------- SYN_REPORT ------------
Event: time 1512561543.105706, type 3 (EV_ABS), code 2 (ABS_Z), value 132
Event: time 1512561543.105706, -------------- SYN_REPORT ------------
Event: time 1512561543.113707, type 3 (EV_ABS), code 2 (ABS_Z), value 131
Event: time 1512561543.113707, -------------- SYN_REPORT ------------
Event: time 1512561543.121721, type 3 (EV_ABS), code 2 (ABS_Z), value 133
Event: time 1512561543.121721, -------------- SYN_REPORT ------------
Event: time 1512561543.129712, type 3 (EV_ABS), code 2 (ABS_Z), value 132

Sometimes, when I look at the analog deadzones diagram, there's a big offset for the center point. That's my picture after pressing the "restore defaults" (and moving the stick doesn't magically centers the rest point):

If I press on the filter noise button, it outputs this:

E HLE: Evdev Calibration: Added axis [ 5 = RZ+ ] to blacklist. Value = 127
E HLE: Evdev Calibration: Added axis [ 3 = RX+ ] to blacklist. Value = 127
E HLE: Evdev Calibration: Added axis [ 2 = LZ+ ] to blacklist. Value = 135
E HLE: Evdev Calibration: Added axis [ 1 = LY+ ] to blacklist. Value = 127
E HLE: Evdev Calibration: Added axis [ 0 = LX+ ] to blacklist. Value = 127

which is perfect for registering my buttons, but of course, doesn't allow me to input joystick signals anymore.
Suggestion: a multiselection drop-down box called "Axis Blacklisting" in which we can disable the problematic axis by ticking them instead of the "Filter noise" button.

Hope it's detailled enough to help you.

Megamouse · 2017-12-08T21:57:39Z

I'll add min and max size to the log.
You can do so as well if you know how to see what the range is.
If it is non negative then the problem is clear

Megamouse · 2017-12-08T22:01:43Z

Axis are checked by ranges from negative to positive space while triggers are checked by 0+ range.

So if your axis has 0+ range it will be handled as trigger.

I could do a button like "handle trigger axis" to whitelist those axis and handle them accordingly

minor style fix

Megamouse · 2017-12-09T07:59:15Z

I added min and max to the log message in order to make sure I'm doing the right thing next

LuismaSP89 · 2017-12-10T03:45:10Z

@Megamouse I opened an issue with input gamepad, (#3924) i don´t know if this is related with your work in this PR.

BTW, this issue happens in master build and with the latest build (artifact) of this PR in appveyor.

Psycho-A · 2017-12-13T04:10:34Z

When will this be merged? Keyboard on Windows is still broken on Master builds as I described it above.

LuismaSP89 · 2017-12-13T12:04:22Z

@Psycho-A Be patient, every PR needs a lot of testing and pass all checks. It's better to be sure that it doesn't break things.

toccata10 · 2017-12-13T14:58:59Z

Checking for the extreme values, I added this in your code:

case EV_ABS:
	{
		auto& dev = device.device;
		int min = libevdev_get_abs_minimum(dev, code);
		int max = libevdev_get_abs_maximum(dev, code);
std::cout <<"code EV_ABS "<< code<< "max " << max <<  std::endl;
std::cout << "code EV_ABS "<< code<<"min " << min <<  std::endl;

Here are the outputs:
xbox 360:

code EV_ABS 1max 32767
code EV_ABS 1min -32768
code EV_ABS 0max 32767
code EV_ABS 0min -32768
code EV_ABS 0max 32767
code EV_ABS 0min -32768
code EV_ABS 4max 32767
code EV_ABS 4min -32768

DragonRise:

code EV_ABS 2max 255
code EV_ABS 2min 0
code EV_ABS 2max 255
code EV_ABS 2min 0
code EV_ABS 2max 255

toccata10 · 2017-12-18T20:55:46Z

I never tested with 2 joysticks after the nice GUI PR. On Linux, the 2nd stick is not usable: it's detected in the Configuration>Pads menu, but it's not detected in the game.
The log shows only "Opened joystick: 'Microsoft X-Box 360 pad' at /dev/input/event20 (fd 23)", never the 2nd one (on event19).
What works is:
*one player on evdev
*the other one on keyboard
May I suggest that in the Configuration>Pads menu, the evdev number appears (ex: Microsoft X-Box 360 pad (event19) and Microsoft X-Box 360 pad (event20) ) ? That could avoid some confusion with multiple contollers.
My log with 2 xbox sticks connected.
RPCS3.log-2sticksPb.gz
The last working version was:
rpcs3-v0.0.4-2017-11-23-7d3a528-8931_linux64 (just before the Gui configuration merge).

Megamouse · 2017-12-18T21:31:08Z

@toccata10 try this change please

edited image

toccata10 · 2017-12-18T22:17:02Z

this renders rpcs3 very unstable (it segfaults).

elad335 · 2017-12-19T04:11:27Z

rpcs3/Emu/Io/PadHandler.h

@@ -319,6 +319,8 @@ class PadHandlerBase
 protected:
 	static const u32 MAX_GAMEPADS = 7;

+	std::array<bool, MAX_GAMEPADS> last_connection_status{{ false, false, false, false, false, false, false }};


use bitset instead?

For 7 boolean values? Seriously?

toccata10 · 2017-12-19T07:01:52Z

Commenting the return std:.. line and adding a continue works: I tested with 2 xbox sticks and it works fine.

and some minor commenting

Asinin3 · 2017-12-24T05:11:52Z

This Pull Request broke Catherine for me and another user with DS3 and DS4. After going to the title screen it won't let you load a game or open the configuration menu. You can move the cursor/selection up and down but pressing X won't do anything.

Edit fixed with new PR that was merged.

spyropt · 2017-12-26T21:31:07Z

This broke NPUB30034 Super Street Fighter 2 Turbo HD using mmjoystick x is not working in the game
everything else appears to work moving up and down
tried the latest build and its the same

Megamouse force-pushed the volley branch from 8a83fe8 to 7f1272e Compare December 1, 2017 09:28

Megamouse changed the title ~~[Input/MMJOY] Final Fixes~~ [WIP] [Input/MMJOY] Final Fixes Dec 1, 2017

Megamouse force-pushed the volley branch 7 times, most recently from d2a58a2 to 4286bfd Compare December 1, 2017 16:06

Megamouse added 2 commits December 1, 2017 22:02

Input: improve MMJOY settings dialog / change threshold behaviour

834bc13

Input: improve evdev settings dialog / change threshold behaviour

27ac7a3

Megamouse force-pushed the volley branch from 4286bfd to 27ac7a3 Compare December 1, 2017 21:06

Megamouse changed the title ~~[WIP] [Input/MMJOY] Final Fixes~~ [Input/MMJOY] Final Fixes Dec 1, 2017

Megamouse changed the title ~~[Input/MMJOY] Final Fixes~~ [Input] Final Fixes (MMJOY + evdev) Dec 1, 2017

Megamouse changed the title ~~[Input] Final Fixes (MMJOY + evdev)~~ [WIP] [Input] Final Fixes (MMJOY + evdev) Dec 2, 2017

Input: evdev fixes and first rumble implementation

6662b51

Megamouse changed the title ~~[WIP] [Input] Final Fixes (MMJOY + evdev)~~ [Input] Final Fixes (MMJOY + evdev) Dec 2, 2017

Megamouse force-pushed the volley branch 2 times, most recently from 2a225ac to f1c14e4 Compare December 2, 2017 21:04

Megamouse force-pushed the volley branch from f1c14e4 to d6127cd Compare December 2, 2017 21:55

Qt/Input: implement mouse button mapping / improve keyboard

5838e27

Megamouse force-pushed the volley branch from d6127cd to 5838e27 Compare December 3, 2017 07:57

Qt: Fix icon size actions

d0364ee

Megamouse force-pushed the volley branch 2 times, most recently from be2d56c to 25f66e2 Compare December 4, 2017 23:45

Input: fix evdev directions, sticks and rumble

892ebad

minor style fix

Megamouse force-pushed the volley branch from 25f66e2 to 892ebad Compare December 9, 2017 07:56

Megamouse force-pushed the volley branch from c78c77f to ce6f0a4 Compare December 10, 2017 09:49

Megamouse force-pushed the volley branch from 78ff0e0 to 784744f Compare December 14, 2017 15:44

elad335 requested changes Dec 19, 2017

View reviewed changes

Input: Fix connection count

8837578

and some minor commenting

Megamouse force-pushed the volley branch from 784744f to 8837578 Compare December 19, 2017 08:28

toccata10 mentioned this pull request Dec 20, 2017

small fix to restore local multiplayer on evdev #3955

Closed

Merge branch 'master' into volley

6532255

Nekotekina merged commit 106de04 into RPCS3:master Dec 21, 2017

toccata10 mentioned this pull request Dec 21, 2017

custom sticks in evdev broken by #3817 #3962

Closed

Megamouse deleted the volley branch December 23, 2017 18:01

atar-axis mentioned this pull request Dec 2, 2018

Switch to a signed range for ABS_ values atar-axis/xpadneo#57

Closed

This comment was marked as off-topic.

Sign in to view

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Input] Final Fixes (MMJOY + evdev) #3817

[Input] Final Fixes (MMJOY + evdev) #3817

Megamouse commented Nov 30, 2017 •

edited

Loading

flash-fire commented Nov 30, 2017

Psycho-A commented Dec 2, 2017 •

edited

Loading

Psycho-A commented Dec 2, 2017

Megamouse commented Dec 2, 2017

Psycho-A commented Dec 3, 2017

toccata10 commented Dec 6, 2017

Megamouse commented Dec 8, 2017

Megamouse commented Dec 8, 2017

Megamouse commented Dec 9, 2017

LuismaSP89 commented Dec 10, 2017 •

edited

Loading

Psycho-A commented Dec 13, 2017 •

edited

Loading

LuismaSP89 commented Dec 13, 2017

toccata10 commented Dec 13, 2017 •

edited

Loading

toccata10 commented Dec 18, 2017

Megamouse commented Dec 18, 2017 •

edited

Loading

toccata10 commented Dec 18, 2017

elad335 Dec 19, 2017 •

edited

Loading

rodjun Dec 19, 2017

toccata10 commented Dec 19, 2017

Asinin3 commented Dec 24, 2017 •

edited

Loading

spyropt commented Dec 26, 2017 •

edited

Loading

This comment was marked as off-topic.

[Input] Final Fixes (MMJOY + evdev) #3817

[Input] Final Fixes (MMJOY + evdev) #3817

Conversation

Megamouse commented Nov 30, 2017 • edited Loading

flash-fire commented Nov 30, 2017

Psycho-A commented Dec 2, 2017 • edited Loading

Psycho-A commented Dec 2, 2017

Megamouse commented Dec 2, 2017

Psycho-A commented Dec 3, 2017

toccata10 commented Dec 6, 2017

Megamouse commented Dec 8, 2017

Megamouse commented Dec 8, 2017

Megamouse commented Dec 9, 2017

LuismaSP89 commented Dec 10, 2017 • edited Loading

Psycho-A commented Dec 13, 2017 • edited Loading

LuismaSP89 commented Dec 13, 2017

toccata10 commented Dec 13, 2017 • edited Loading

toccata10 commented Dec 18, 2017

Megamouse commented Dec 18, 2017 • edited Loading

toccata10 commented Dec 18, 2017

elad335 Dec 19, 2017 • edited Loading

Choose a reason for hiding this comment

rodjun Dec 19, 2017

Choose a reason for hiding this comment

toccata10 commented Dec 19, 2017

Asinin3 commented Dec 24, 2017 • edited Loading

spyropt commented Dec 26, 2017 • edited Loading

This comment was marked as off-topic.

Megamouse commented Nov 30, 2017 •

edited

Loading

Psycho-A commented Dec 2, 2017 •

edited

Loading

LuismaSP89 commented Dec 10, 2017 •

edited

Loading

Psycho-A commented Dec 13, 2017 •

edited

Loading

toccata10 commented Dec 13, 2017 •

edited

Loading

Megamouse commented Dec 18, 2017 •

edited

Loading

elad335 Dec 19, 2017 •

edited

Loading

Asinin3 commented Dec 24, 2017 •

edited

Loading

spyropt commented Dec 26, 2017 •

edited

Loading