Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small fix to restore local multiplayer on evdev #3955

Closed
wants to merge 1 commit into from
Closed

small fix to restore local multiplayer on evdev #3955

wants to merge 1 commit into from

Conversation

toccata10
Copy link
Contributor

All credit goes to @Megamouse . There's a big #3817, but it might take some time before it's ready.
Since the nice gui configuration, only one evdev gamepad is usable on master. So, it's a regression.
I believe it would be very nice to restore the local multiplayer ability on Linux (without waiting for the #3817).
It's a very small fix.
Maybe @Megamouse wants to push this under his own name ?

@Megamouse
Copy link
Contributor

I already pushed it.
but someone:tm: hasn't had time to reviiew yet xD

@toccata10
Copy link
Contributor Author

Sorry, I couldn't find it in the waiting queue. I see it's in the #3817 and it fixes the multiplayer, but the #3817 also breaks the compatibility with custom sticks (no left direction for example, for me) in evdev, so I think it's not in a mergeable state yet (and it could take a little while to be ready).
My idea was to just fix this in the meantime (because it's really cool to be able to play with a friend on the latest master (without recompiling)). But if you think it's best to wait for a correct #3817, just let me know.

@Megamouse
Copy link
Contributor

not at all. i don't care what's merged first.

the thing is that evdev is pretty much broken anyway for certain dumb controllers until the workaround (for example dedicated trigger-list) is implemented.

Current master is the real broken code. it's just wrong how I checked for triggers in the first place.
and the original implementation was even worse.

@toccata10
Copy link
Contributor Author

OK, so let's hope someone merges this: it'll make Linux users happy.

@Megamouse
Copy link
Contributor

should be obsolete now that 3817 is merged

@toccata10
Copy link
Contributor Author

Yes. Closing this.

@toccata10 toccata10 closed this Dec 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants