Fix NPE in Set Facing tool #4957
Merged
+36
−122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now handle the case where a token does not have a facing. In that case, the tool updates the other clients to also remove the facing.
A token still may not have a facing, but this must now be determined by `Token.hasFacing()`. `Token.getFacing()` will never return `null` but will provide the default of -90°, which removes the case work that several callers had to consistently perform. In order to remove a token's facing, `Token.removeFacing()` can now be used as `Token.setFacing()` no longer accepts `null`. Also remove some unused and redundant code in related places.
cwisniew
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Fixes #4956
Description of the Change
The Set Facing tool now handles the case where a token has no facing at the end of the operation (see changes in
FacingTool.mousePressed()).The rest of the changes are easy cleanup related to facing, but don't affect functionality:
Token.hasFacing()instead ofToken.getFacing() == nullToken.getFacingInDegrees()where it helps.Token.removeFacing()to clear facing rather than usingToken.setFacing(null).Token.getFacing()Token's API.Possible Drawbacks
None
Documentation Notes
N/A
Release Notes
This change is