Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NPE in Set Facing tool #4957

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Fix NPE in Set Facing tool #4957

merged 2 commits into from
Oct 2, 2024

Commits on Sep 27, 2024

  1. Fix NPE in Set Facing tool 

    We now handle the case where a token does not have a facing. In that case, the tool updates the other clients to also
remove the facing.
    @kwvanderlinde
    kwvanderlinde committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    ae4cce9 View commit details
    Browse the repository at this point in the history

  2. Token no longer has a nullable facing. 

    A token still may not have a facing, but this must now be determined by `Token.hasFacing()`. `Token.getFacing()` will
never return `null` but will provide the default of -90°, which removes the case work that several callers had to
consistently perform.

In order to remove a token's facing, `Token.removeFacing()` can now be used as `Token.setFacing()` no longer accepts
`null`.

Also remove some unused and redundant code in related places.
    @kwvanderlinde
    kwvanderlinde committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    d8987b1 View commit details
    Browse the repository at this point in the history