Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add reaction type to raw events and users iterator #9836

Merged
merged 3 commits into from
May 18, 2024
Merged

Add reaction type to raw events and users iterator #9836

merged 3 commits into from
May 18, 2024

Conversation

Puncher1
Copy link
Contributor

Summary

This PR adds the reaction type to RawReactionActionEvent and reaction.users async iterator.

Related PRs:

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@Rapptz
Copy link
Owner

Rapptz commented May 17, 2024

This has conflicts now.

@Puncher1
Copy link
Contributor Author

This has conflicts now.

Resolved

Vioshim
Vioshim reviewed May 17, 2024
View reviewed changes
discord/reaction.py Outdated Show resolved Hide resolved
@Puncher1
Change how type is handled if it's None
96f642f 
Send the value of the type only if it's not None. If it's None, let Discord decide.
@Puncher1 Puncher1 requested a review from Rapptz May 18, 2024 14:18
@Rapptz Rapptz merged commit f77ba71 into Rapptz:master May 18, 2024
8 checks passed
@Puncher1 Puncher1 deleted the reaction-type branch August 7, 2024 16:02
@alkshmir alkshmir mentioned this pull request Aug 31, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeshardmind mikeshardmind mikeshardmind left review comments

@Vioshim Vioshim Vioshim left review comments

@Rapptz Rapptz Rapptz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Puncher1 @Rapptz @mikeshardmind @Vioshim