Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add type query param for get reactions endpoint #6377

Merged
merged 4 commits into from
May 15, 2024

Conversation

Mateo-tem
Copy link
Contributor

Missing on #6056 (#6056 (comment))

| limit? | integer | Max number of users to return (1-100) | 25 |
| Field | Type | Description | Default |
|--------|-----------|--------------------------------------------------|---------|
| type? | integer | The reaction type (0 for normal and 1 for super) | 0 |
Copy link
Contributor

@jaw0r3k jaw0r3k Aug 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cant we use there reaction type instead of just numbers?

Copy link
Contributor

@JJRcop JJRcop Sep 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The author of this PR can't change anything with the API and is only documenting what is already there. I believe your feedback is going to the wind.

Copy link
Contributor

@jaw0r3k jaw0r3k Sep 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well not what i meant
just make a table for reaction type

to show NORMAL = 0 and BURST = 1
easier to mention afterwards

@advaith1
Copy link
Contributor

the standard for type enums is to document the field type as integer and to link to the table in the field description. for example see the channel and message objects

@colinloretz colinloretz merged commit 5f91d74 into discord:main May 15, 2024
3 checks passed
suneettipirneni added a commit to twilight-rs/twilight that referenced this pull request Jul 13, 2024
Refs:
- discord/discord-api-docs#6375
- discord/discord-api-docs#6377

This PR renames the old `ReactionType` to `EmojiReactionType` as the
concept of a reaction type now exists in the API.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants