Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use caching to speed up workflows #760

Merged
merged 2 commits into from
Mar 26, 2023
Merged

Conversation

validcube
Copy link
Member

@validcube validcube commented Mar 26, 2023

🤖 Speed up workflows

Enable GitHub cache to speed up workflows

📜 Note

Note

Before caching: Actions usually take around 10~ish minutes to complete
With caching (first-run): Actions usually take around 15~ish minutes to complete
With caching (cached): Actions usually take around 6-8~ish minutes to complete

👋 Resolve

resolve: #611

Additional...

Please don't look at the past Please don't look at the past Please don't look at the past Please don't look at the past Please don't look at the past https://user-images.githubusercontent.com/93124920/227767135-bc7909db-6b63-4541-860d-fec490925b0f.png

@validcube validcube self-assigned this Mar 26, 2023
@validcube validcube force-pushed the flutter branch 2 times, most recently from 4d86b6c to deac899 Compare March 26, 2023 10:00
Cached items: Dart and npm packages

ci(test): Bug Busters

ci(build): use GitHub cache

ci(deps): update deprecated

ci(cache): fix get hash for `pubspec.lock`

ci(cache): get cache from env

Update pull-request-build.yml

Update pull-request-build.yml

Update pull-request-build.yml

Update pull-request-build.yml

OH MY GODDDD

finally...?
@validcube validcube merged commit a79f883 into ReVanced:dev Mar 26, 2023
@PalmDevs
Copy link
Member

@evademaster You did not need to revert that! It works perfectly fine without those. See my test.

@Ushie
Copy link
Member

Ushie commented Mar 26, 2023

@evademaster You did not need to revert that! It works perfectly fine without those. See my test.

Flutter can build APKs that aren't signed, but we do need them to be signed

@PalmDevs
Copy link
Member

@evademaster You did not need to revert that! It works perfectly fine without those. See my test.

Flutter can build APKs that aren't signed, but we do need them to be signed

It's signed in the next step. Look at the workflow file.

@validcube
Copy link
Member Author

validcube commented Mar 26, 2023

@evademaster You did not need to revert that! It works perfectly fine without those. See my test.

Flutter can build APKs that aren't signed, but we do need them to be signed

It's signed in the next step. Look at the workflow file.

I believe, you might’ve incorrectly configured your workflow, because ilharp/sign-android-release has these parameters to be filled out; otherwise, it will fail due to being unable to sign an application without key.

signingKey
keyAlias
keyStorePassword

Check your configuration:
https://github.com/PalmDevs/revanced-manager/blob/46acc3d8ae50979a4ce25c45eb9b0e6ebf3a338d/.github/workflows/release.yml#L44-L52

Edit: Resolved

@PalmDevs
Copy link
Member

PalmDevs commented Mar 26, 2023

I believe, you might’ve incorrectly configured your workflow, because ilharp/sign-android-release has these parameters to be filled out; otherwise, it will fail due to being unable to sign an application without key.

signingKey
keyAlias
keyStorePassword

@evademaster

No? I've filled them and generated my own keystore. See my workflow configuration.

I've also filled them accordingly. Plus the workflow ran without any issues.

Screenshot_20230326_203613_Chrome.jpg

Aunali321 added a commit that referenced this pull request Apr 20, 2023
* feat: remove notice about stale development [skip ci]

* feat(ci): update crowdin workflow to use new main branch

* ci: use `semantic-release` (#746)

* ci(release): fix wrong artifact name and ci not uploading build

* ci: use caching to speed up workflows (#760)

Use caching to speed up workflows: 9-14 minutes (ish) to 6-8 minutes (ish)

Commits:
* ci(release): use GitHub cache

* ci(release): restore signing

* ci(release): remove unnecessary variables in flutter build step

* ci(release): fix step not moving artifact to accessible path

* ci(release): use appropriate npm commands for ci environment

* ci(release): fix argument parsing of npm exec

* ci: dart analyser (#761)

* ci: dart analyser

* ci(analyser): clarify the dart analysing step

* refactor: ignore generated files

* ci(analyser): apply suggestion from code-reviewer

Co-Authored-By: Palm <[email protected]>

* ci(analyser): apply suggestion from code-reviewer

Co-Authored-By: Palm <[email protected]>

* ci(analyser): apply suggestion from code-reviewer

Co-authored-by: Palm <[email protected]>

---------

Co-authored-by: Palm <[email protected]>

* ci(analyze): only run when necessary (#766)

* ci(analyser): only run on lib/`.dart` changes

* ci(analyser): runs on workflow changes

* ci(analyze): run on all dart file changes

---------

Co-authored-by: Palm <[email protected]>

* ci(release): update node dependencies

* chore(CHANGELOG): reset changelog

* feat: confirmation dialog for deleting keystore (#764)

* feat: confirmation dialog for deleting keystore

* refactor(i18n): apply suggestion from code-reviewer

Co-authored-by: Ushie <[email protected]>

* refactor: apply suggestion from code-reviewer

Co-authored-by: Mipirakas <[email protected]>

---------

Co-authored-by: Ushie <[email protected]>
Co-authored-by: Mipirakas <[email protected]>

* ci(release): update semantic-release

* feat: improve ux (#752)

* feat: restart app toast when changing sources, api url

* fix: potentially fix manager stuck on black screen

* feat: remove select all patches chip

* feat: show all apps and recommended versions

* chore(i18n): remove unused strings

remove unused strings left out in 7e05bca

* feat: select install type before patching

* feat: update patches button (#782)

* feat: update patches button

* feat: show toast when force refresh

* chore: don't translate "ReVanced Manager" and "ReVanced Patches"

* Revert "feat: select install type before patching"

This reverts commit 74e0c09.

* feat: rename recommended patches to default patches

* feat: add missing localization

* feat: display restart app toast for resetting source

---------

Co-authored-by: EvadeMaster <[email protected]>

* feat: add option to import/export keystore (#776)

* feat: add option to import/export keystore

* change the order of import/export keystore buttons

* feat: add option to change the keystore password

* feat: trim extra space when setting custom source (#771)

* chore: update dependencies (#772)

* chore: updated some dependencies

* refactor: reimplemented cache interceptor

* Revert "Updated dependencies & migrated breaking changes"

This reverts commit e6743b0.

* chore: migrated flutter_local_notifications

* revert: reimplemented cache interceptor

* fix: open contributor links externally (#791)

* feat: auto select default patches

* style: sort imports

* feat: progress bar for manager updates

* feat: appreciation message for new contributors

* docs: remove alpha disclaimer

* feat: disable selecting installed apps for nonroot

* feat: warning for armv7 devices

* chore: add missing translations

* feat: resetting source to default dismiss the sources pop-up (#797)

* feat: resetting source to default dismiss the sources pop-up

* chore: format using `dart format`

---------

Co-authored-by: Ushie <[email protected]>
Co-authored-by: Palm <[email protected]>
Co-authored-by: EvadeMaster <[email protected]>
Co-authored-by: Mipirakas <[email protected]>
Co-authored-by: Sebok Andras <[email protected]>
Co-authored-by: Aman Sikarwar <[email protected]>
Co-authored-by: Yaros <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: improve workflow
4 participants