ci: dart analyser #761
Merged
ci: dart analyser #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PalmDevs
previously requested changes
Mar 28, 2023
.github/workflows/analyser.yml
Outdated
| @@ -0,0 +1,28 @@ | |||
| name: Dart analyser | |||
There was a problem hiding this comment.
Please rename this to Analyze Code or something else. Same with the file name. analyze.yml would be nice.
|
Also if anything is related to CI, please always use the |
Co-Authored-By: Palm <[email protected]>
|
You.. little shid. 💩 |
Co-Authored-By: Palm <[email protected]>
grrr, the refactor change was |
Co-authored-by: Palm <[email protected]>
PalmDevs
previously requested changes
Mar 28, 2023
PalmDevs
dismissed
their stale review
Stale again, you're too quick with the commits xD
PalmDevs
approved these changes
Mar 28, 2023
Where are your manners? that's highly inappropriate. |
|
Aunali321
added a commit
that referenced
this pull request
Apr 20, 2023
* feat: remove notice about stale development [skip ci] * feat(ci): update crowdin workflow to use new main branch * ci: use `semantic-release` (#746) * ci(release): fix wrong artifact name and ci not uploading build * ci: use caching to speed up workflows (#760) Use caching to speed up workflows: 9-14 minutes (ish) to 6-8 minutes (ish) Commits: * ci(release): use GitHub cache * ci(release): restore signing * ci(release): remove unnecessary variables in flutter build step * ci(release): fix step not moving artifact to accessible path * ci(release): use appropriate npm commands for ci environment * ci(release): fix argument parsing of npm exec * ci: dart analyser (#761) * ci: dart analyser * ci(analyser): clarify the dart analysing step * refactor: ignore generated files * ci(analyser): apply suggestion from code-reviewer Co-Authored-By: Palm <[email protected]> * ci(analyser): apply suggestion from code-reviewer Co-Authored-By: Palm <[email protected]> * ci(analyser): apply suggestion from code-reviewer Co-authored-by: Palm <[email protected]> --------- Co-authored-by: Palm <[email protected]> * ci(analyze): only run when necessary (#766) * ci(analyser): only run on lib/`.dart` changes * ci(analyser): runs on workflow changes * ci(analyze): run on all dart file changes --------- Co-authored-by: Palm <[email protected]> * ci(release): update node dependencies * chore(CHANGELOG): reset changelog * feat: confirmation dialog for deleting keystore (#764) * feat: confirmation dialog for deleting keystore * refactor(i18n): apply suggestion from code-reviewer Co-authored-by: Ushie <[email protected]> * refactor: apply suggestion from code-reviewer Co-authored-by: Mipirakas <[email protected]> --------- Co-authored-by: Ushie <[email protected]> Co-authored-by: Mipirakas <[email protected]> * ci(release): update semantic-release * feat: improve ux (#752) * feat: restart app toast when changing sources, api url * fix: potentially fix manager stuck on black screen * feat: remove select all patches chip * feat: show all apps and recommended versions * chore(i18n): remove unused strings remove unused strings left out in 7e05bca * feat: select install type before patching * feat: update patches button (#782) * feat: update patches button * feat: show toast when force refresh * chore: don't translate "ReVanced Manager" and "ReVanced Patches" * Revert "feat: select install type before patching" This reverts commit 74e0c09. * feat: rename recommended patches to default patches * feat: add missing localization * feat: display restart app toast for resetting source --------- Co-authored-by: EvadeMaster <[email protected]> * feat: add option to import/export keystore (#776) * feat: add option to import/export keystore * change the order of import/export keystore buttons * feat: add option to change the keystore password * feat: trim extra space when setting custom source (#771) * chore: update dependencies (#772) * chore: updated some dependencies * refactor: reimplemented cache interceptor * Revert "Updated dependencies & migrated breaking changes" This reverts commit e6743b0. * chore: migrated flutter_local_notifications * revert: reimplemented cache interceptor * fix: open contributor links externally (#791) * feat: auto select default patches * style: sort imports * feat: progress bar for manager updates * feat: appreciation message for new contributors * docs: remove alpha disclaimer * feat: disable selecting installed apps for nonroot * feat: warning for armv7 devices * chore: add missing translations * feat: resetting source to default dismiss the sources pop-up (#797) * feat: resetting source to default dismiss the sources pop-up * chore: format using `dart format` --------- Co-authored-by: Ushie <[email protected]> Co-authored-by: Palm <[email protected]> Co-authored-by: EvadeMaster <[email protected]> Co-authored-by: Mipirakas <[email protected]> Co-authored-by: Sebok Andras <[email protected]> Co-authored-by: Aman Sikarwar <[email protected]> Co-authored-by: Yaros <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 - Dart analyser
Dart analyser to analyse Dart code quality, and will fail on warning
Resolved #671