Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update type declarations in codebase #608

Closed
kwonoj opened this issue Oct 27, 2015 · 3 comments
Closed

Update type declarations in codebase #608

kwonoj opened this issue Oct 27, 2015 · 3 comments

Comments

@kwonoj
Copy link
Member

kwonoj commented Oct 27, 2015

Such as PR #585, #597, some of type declaration signature in codebase need to be checked & revised if required.
kwonoj added a commit to kwonoj/rxjs that referenced this issue Oct 27, 2015
@kwonoj
refactor(Subject): update type declaration for Subject
9264bd1 
relates to ReactiveX#608
This was referenced Oct 27, 2015
Closed
Closed
kwonoj added a commit to kwonoj/rxjs that referenced this issue Nov 1, 2015
@kwonoj
refactor(CoreOperators): correct class type constraint passed to oper…
10ab26d 
…ator

relates to ReactiveX#608, closes ReactiveX#635
@kwonoj kwonoj mentioned this issue Nov 1, 2015
Closed
kwonoj added a commit to kwonoj/rxjs that referenced this issue Nov 1, 2015
@kwonoj
refactor(CoreOperators): correct class type constraint passed to oper…
5f03872 
…ator

relates to ReactiveX#608, closes ReactiveX#635
kwonoj added a commit to kwonoj/rxjs that referenced this issue Nov 1, 2015
@kwonoj
refactor(CoreOperators): correct class type constraint passed to oper…
d96cbdf 
…ator

relates to ReactiveX#608, closes ReactiveX#635
benlesh pushed a commit that referenced this issue Nov 3, 2015
@kwonoj @benlesh
refactor(Subject): update type declaration for Subject
61e173b 
relates to #608
kwonoj added a commit to kwonoj/rxjs that referenced this issue Nov 4, 2015
@kwonoj
refactor(CoreOperators): correct class type constraint passed to oper…
a251232 
…ator

relates to ReactiveX#608, closes ReactiveX#635
@kwonoj
Copy link
Member Author

kwonoj commented Nov 4, 2015

repeat also need to be updated, does not have default value for parameter.

image

@kwonoj kwonoj mentioned this issue Nov 5, 2015
Closed
kwonoj added a commit that referenced this issue Nov 5, 2015
@kwonoj @benlesh
refactor(CoreOperators): correct class type constraint passed to oper…
b461e72 
…ator

relates to #608, closes #635
@benlesh
Copy link
Member

benlesh commented Jan 15, 2016

Since this is such a generic issue, I'm going to close it for now. Ideally, we'll find more specific issues around typing and file them individually for specific files or something. "Update types in the whole library" isn't something easily resolved in a few commits.

@benlesh benlesh closed this as completed Jan 15, 2016
@lock
Copy link

lock bot commented Jun 7, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kwonoj @benlesh