refactor(Subscriber): update type declaration for Subscriber #597
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subscriber
itself does have type constraint via generic, it actually doesn't work for values or creating new observables, like below code snippetshould be caught by compiler since type constraint of given subscriber is
number
, but it doesn't bySubscriber::next()
does not apply type constraint for values.type constraint is not applied for values
PR makes
Subscriber
now follows given types more explicitly let compiler allows type checking for build time.type constraint applied after changes
This change also brings correct generic type checking for operators either operator passes same type or either different type like
<in, out>
. No functional changes are introduced, change affects only for type declaration.