fix(retry): Ensure teardown happens before resubscription with synchr… #5621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In fact, I'd bet there's an issue like this with |
cartant
reviewed
Aug 4, 2020
…onous observables Related: ReactiveX#5620 - Resolves an issue where all teardowns would not execute until the result observable was complete if the source was synchronous BREAKING CHANGE: Removed an undocumented behavior where passing a negative count argument to `retry` would result in an observable that repeats forever.
BREAKING CHANGE: Leaked implementation detail `_unsubscribeAndRecycle` has been removed. Just use new `Subscription` objects
benlesh
force-pushed
the
fix/retry-should-sub-after-teardown
branch
from
f506399
to
27d7834
Compare
|
Addressed comments. Also removed |
cartant
approved these changes
Aug 5, 2020
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…onous observables
Related: #5620
BREAKING CHANGE: Removed an undocumented behavior where passing a negative count argument to
retrywould result in an observable that repeats forever.