Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade deps, breaking prod. Update README.md #305

Closed
wants to merge 1 commit into from

Conversation

wilsonge
Copy link
Contributor

@wilsonge wilsonge commented Jul 18, 2017

Also fixes #293

Since typescript 2.4 the following errors occur:

[at-loader] ./lib/services/search.service.ts:195:24 
    TS2345: Argument of type 'Schema | Schema[]' is not assignable to parameter of type 'SwaggerSchema'.
  Type 'Schema[]' has no properties in common with type 'SwaggerSchema'. 

Downgrading to typescript 2.3.4 (the latest typescript 2.3.x series) fixes this.

On accessing the public page there were a variety of console errors that stemmed from zone 0.8.13 (angular/zone.js#832). Downgrading to 0.8.12 fixed this error (and seems to be recommended)

I've also updated the docs to suggest running the prod build before npm start as otherwise you got the error:

[at-loader] Checking finished with 3 errors
[at-loader] ./lib/bootstrap.ts:2:36 
    TS2307: Cannot find module '../compiled/lib/app.module.ngfactory'. 

Because the compiled directory hadn't been created yet.

@wilsonge
Copy link
Contributor Author

wilsonge commented Jul 20, 2017

@RomanGotsiy so with your latest commit this afternoon, things seem to work as per the README. On running npm start I do get:

[at-loader] Checking finished with 1 errors
[at-loader] ./lib/bootstrap.ts:2:36 
    TS2307: Cannot find module '../compiled/lib/app.module.ngfactory'. 

(although it doesn't seem to interupt display of the page)

@RomanHotsiy
Copy link
Member

@wilsonge awesome!

Cannot find module '../compiled/lib/app.module.ngfactory'.
Yes, this message is OK. I will try to get rid of this as it may confuse contributors!

Can I close this PR then?

@wilsonge wilsonge closed this Jul 21, 2017
@wilsonge wilsonge deleted the fix-production-build branch July 21, 2017 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

npm run build:prod currently fails
2 participants