Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix event creation #306

Merged
merged 1 commit into from
Jul 18, 2017
Merged

Fix event creation #306

merged 1 commit into from
Jul 18, 2017

Conversation

wilsonge
Copy link
Contributor

As per https://developer.mozilla.org/en/docs/Web/API/MouseEvent true isn't a valid parameter and causes an error to be thrown in typescript 2.4 (correctly). This set of parameters matches that in the catch below using document.createEvent

@RomanHotsiy
Copy link
Member

Hey @wilsonge,
Thanks for fixing this! 👍
Can #305 be closed in favor of this?

@wilsonge
Copy link
Contributor Author

No - unfortunately not - the

[at-loader] ./lib/services/search.service.ts:195:24 
    TS2345: Argument of type 'Schema | Schema[]' is not assignable to parameter of type 'SwaggerSchema'.
  Type 'Schema[]' has no properties in common with type 'SwaggerSchema'. 

thing isn't fixed here. and that one seems like a complete rabbit hole from a 20 minute run through it. I'm not sure I have the ability to fix that one. So this fixes one of the errors from #305 but #305 is still required for now

@RomanHotsiy
Copy link
Member

OK, thanks for diving in!
I will try to fix the second one later today.

@wilsonge
Copy link
Contributor Author

By the way the zone.js thing from #305 is required either way even if we fix the typescript. It looks like that's a totally broken version.

@RomanHotsiy RomanHotsiy merged commit 6bb3bd8 into Redocly:master Jul 18, 2017
@wilsonge wilsonge deleted the patch-1 branch July 18, 2017 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants