Show dialog after completed or error purchasing #1246
Conversation
vegaro
changed the base branch from
main
to
cesar/pwl-197-add-support-for-purchasing
| if (state.displayCompletedPurchaseMessage) { | ||
| PurchaseAlertDialog(viewModel, "Purchase was successful") | ||
| } else if (state.displayErrorPurchasingMessage) { | ||
| PurchaseAlertDialog(viewModel, "There was a purchasing error") |
There was a problem hiding this comment.
I might change this to reuse the dialog for restoring too. In that case the text will be set from the viewmodel. What do you think @tonidero
...ter/src/main/java/com/revenuecat/paywallstester/ui/screens/paywall/PaywallScreenViewModel.kt
Outdated
Show resolved
Hide resolved
| } | ||
| } | ||
|
|
||
| override fun onPurchaseError(error: PurchasesError) { |
There was a problem hiding this comment.
I guess we are not displaying the error message in the dialog right? I wonder if instead of a boolean, we should use a nullable string in the state so we can display the error message.
There was a problem hiding this comment.
I see we already made the conversion to a nullable string in the followup PR... So then the question is whether we want to include the error in the dialog... IMO, it might be a good idea for a tester app since it would be easier to visualize errors in case they happen when downloaded from the play store.
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## paywalls #1246 +/- ##
=========================================
Coverage 85.48% 85.48%
=========================================
Files 187 187
Lines 6346 6346
Branches 923 923
=========================================
Hits 5425 5425
Misses 564 564
Partials 357 357 ☔ View full report in Codecov by Sentry. |
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| @Composable | ||
| private fun PurchaseAlertDialog( |
There was a problem hiding this comment.
We might want to extract this to a different file... But for now, I think it's fine to keep here.
Displays an AlertDialog after purchase is successful or if it errors out