Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show dialog messages when restoring #1247

Merged

Conversation

vegaro
Copy link
Contributor

@vegaro vegaro commented Sep 13, 2023

Hooked up restoring listeners and displayed messages in a dialog

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (6f3d8ae) 85.48% compared to head (aab9a0e) 85.48%.

Additional details and impacted files
@@             Coverage Diff              @@
##           show-dialog    #1247   +/-   ##
============================================
  Coverage        85.48%   85.48%           
============================================
  Files              187      187           
  Lines             6346     6346           
  Branches           923      923           
============================================
  Hits              5425     5425           
  Misses             564      564           
  Partials           357      357           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@tonidero tonidero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

if (value is PaywallScreenState.Loaded) {
_state.update {
value.copy(
dialogText = "There was an error restoring purchases",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might be worth displaying the error message in the alert... I understand we wouldn't do that in a user-facing app, but it might be helpful as a tester app... Wdyt?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good! going to merge this into the other PR and make the change there

@vegaro vegaro merged commit d164409 into show-dialog Sep 13, 2023
7 checks passed
@vegaro vegaro deleted the cesar/pwl-198-add-support-for-restoring-purchases branch September 13, 2023 13:21
vegaro added a commit that referenced this pull request Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants