-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show dialog messages when restoring #1247
Show dialog messages when restoring #1247
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## show-dialog #1247 +/- ##
============================================
Coverage 85.48% 85.48%
============================================
Files 187 187
Lines 6346 6346
Branches 923 923
============================================
Hits 5425 5425
Misses 564 564
Partials 357 357 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
if (value is PaywallScreenState.Loaded) { | ||
_state.update { | ||
value.copy( | ||
dialogText = "There was an error restoring purchases", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it might be worth displaying the error message in the alert... I understand we wouldn't do that in a user-facing app, but it might be helpful as a tester app... Wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good! going to merge this into the other PR and make the change there
Hooked up restoring listeners and displayed messages in a dialog