Support BC7 #1737
Merged
Support BC7 #1737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the minimum required changes to be able to compile with BC7. - Bumps the version to `8.0.0-SNAPSHOT`. - Bumps the `minSdkVersion` to 21 (Android 5.0). - `UpgradeInfo` now takes a `ReplacementMode` instead of the now-removed `ProrationMode`. - Removed the deprecated `GoogleProrationMode`, as it was using the now-removed `ProrationMode`. - Removes deprecated `StoreTransaction` constructor taking a `GoogleProrationMode`. - Removes `PurchaseParams.Builder.googleProrationMode()`. - Uses Billing Library `7.0.0`. - Added `GoogleReplacementModeAPI.java`
### Description This exposes the info for installment plans so developers can use it. The new API looks like: - New `InstallmentsInfo` interface with `commitmentPaymentsCount` and `subsequentCommitmentPaymentsCount` fields. - New `GoogleInstallmentsInfo` data class implementing previous interface. - New method in `SubscriptionOption`/`GoogleSubscriptionOption` exposing the installments info.
PR to support pending prepaid purchase as a new feature added in BC7. This will be enabled by default but can be disabled through an option in `PurchasesConfiguration`: `pendingTransactionsForPrepaidPlansEnabled `.
Generated by 🚫 Danger |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 8.0.0-dev #1737 +/- ##
============================================
Coverage ? 82.99%
============================================
Files ? 222
Lines ? 7576
Branches ? 1070
============================================
Hits ? 6288
Misses ? 872
Partials ? 416 ☔ View full report in Codecov by Sentry. |
vegaro
reviewed
Jun 6, 2024
| @@ -51,7 +51,7 @@ Or view / build our Android sample app: | |||
| ## Requirements | |||
| - Java 8+ | |||
| - Kotlin 1.5.0+ | |||
There was a problem hiding this comment.
ohh do we need to update this?
There was a problem hiding this comment.
Ohh good catch! Will update that since I'm writing the migration docs.
| @@ -277,6 +277,7 @@ class Purchases internal constructor( | |||
| val configuration = PurchasesConfiguration.Builder(context, apiKey) | |||
| .appUserID(appUserID) | |||
| .dangerousSettings(DangerousSettings(customEntitlementComputation = true)) | |||
| .pendingTransactionsForPrepaidPlansEnabled(true) | |||
There was a problem hiding this comment.
I believe we want to enable it by default for companies using customEntitlementComputation. We can provide an option to disable it later if needed though, but we try to keep the API very small in the customEntitlementComputation flavor I think.
This was referenced Jun 6, 2024
Closed
Closed
Merged
tonidero
added a commit
that referenced
this pull request
Jun 11, 2024
For a full migration guide check [v8-MIGRATION.md](migrations/v8-MIGRATION.md) ### Breaking Changes * Support BC7 (#1737) via Toni Rico (@tonidero) #### New APIs: - `SubscriptionOption.installmentInfo` which contains information about installment plans you might want to display in your paywall. - `PurchasesConfiguration.pendingTransactionsForPrepaidPlansEnabled` allows to enable pending prepaid subscriptions. #### Breaking changes - Increase min Sdk to 21. This was increased in BC7 - Increase min kotlin version to 1.7.0 - Remove `UpgradeInfo` - Remove all `purchasePackage` and `purchaseProduct` methods using `UpgradeInfo`. If you want to perform upgrades/downgrades, please migrate to use the `purchase(PurchaseParams)` method, which has options to perform that operation. ### Other Changes * Bump kotlin to 1.8 (#1726)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for BC7 and related new features.
New APIs:
SubscriptionOption.installmentInfowhich contains information about installment plans you might want to display in your paywall.PurchasesConfiguration.pendingTransactionsForPrepaidPlansEnabledallows to enable pending prepaid subscriptions.Breaking changes
UpgradeInfopurchasePackageandpurchaseProductmethods usingUpgradeInfo. If you want to perform upgrades/downgrades, please migrate to use thepurchase(PurchaseParams)method, which has options to perform that operation.